Closed Bug 1509994 Opened 1 year ago Closed 1 year ago

Move code from video_engine from media/webrtc/trunk/webrtc to elsewhere in tree

Categories

(Core :: WebRTC: Audio/Video, enhancement, P3)

63 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: dminor, Assigned: dminor)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

This code does not exist in upstream webrtc.org, but based upon the headers in the files, it once did. Rather than restoring it each time we pull from upstream webrtc.org, we should move it elsewhere in tree.

It appears to be used by dom/media/systemservices/VideoEngine.cpp, so that seems like the logical place to put it.

We should also take the opportunity to see if we can switch to supported interfaces for accessing video / desktop capture rather than relying on code that has been undeleted from upstream.
Assignee: nobody → dminor
Historically this code was part of webrtc.org but has since been removed
from upstream. Rather than maintaining it as a local diff against upstream,
we should just move it to where it is used.
Depends on D13095
Phabricator choked on the size of the json update patch and I had to manually split it into two.
Status: NEW → ASSIGNED
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0fd399c6caab
Move video_engine from webrtc to systemservices; r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/6cea864da2b6
Update gn generated json files; r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/cab408925a76
Update gn generated json files (part 2); r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/352048c07693
Regenerate moz.build files; r=pehrsons
You need to log in before you can comment on or make changes to this bug.