1510178 - remove broadcasters from common/

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1489447 +++

Remove broadcasters from common/

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1510178_debroadcaster_common.patch

History is a seamonkey thing - https://searchfox.org/comm-central/source/common/src/viewSource.xul#300 so we don't need to worry about navigation.

Their viewsource looks non salvageable, we probably should move this to mail and remove all the unneeded junk. But then again, I didn't know they removed the stand-alone view source in Firefox (bug 1418403).

This does it for now.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 9027847 [details] [diff] [review]
bug1510178_debroadcaster_common.patch

Review of attachment 9027847 [details] [diff] [review]:
-----------------------------------------------------------------

::: common/src/viewSource.xul
@@ +141,5 @@
>                accesskey="&forwardCmd.accesskey;"
>                command="Browser:Forward"
>                observes="viewSourceNavigation"/>
>      <menuseparator observes="viewSourceNavigation"/>
> +#else

This looks wrong. Where is the #endif??

Comment 3

[Geoff Lankow (:darktrojan)]

Yeesh, how did I miss that? Good thing somebody's awake.

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: bug1510178_debroadcaster_common.patch

Updated

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2a56bbf37048
remove broadcasters from common/. r=darktrojan