Closed Bug 1510178 Opened 11 months ago Closed 11 months ago

remove broadcasters from common/

Categories

(Thunderbird :: General, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 65.0

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1489447 +++

Remove broadcasters from common/
History is a seamonkey thing - https://searchfox.org/comm-central/source/common/src/viewSource.xul#300 so we don't need to worry about navigation.

Their viewsource looks non salvageable, we probably should move this to mail and remove all the unneeded junk. But then again, I didn't know they removed the stand-alone view source in Firefox (bug 1418403).

This does it for now.
Attachment #9027847 - Flags: review?(geoff)
Attachment #9027847 - Flags: review?(geoff) → review+
Keywords: checkin-needed
Comment on attachment 9027847 [details] [diff] [review]
bug1510178_debroadcaster_common.patch

Review of attachment 9027847 [details] [diff] [review]:
-----------------------------------------------------------------

::: common/src/viewSource.xul
@@ +141,5 @@
>                accesskey="&forwardCmd.accesskey;"
>                command="Browser:Forward"
>                observes="viewSourceNavigation"/>
>      <menuseparator observes="viewSourceNavigation"/>
> +#else

This looks wrong. Where is the #endif??
Keywords: checkin-needed
Yeesh, how did I miss that? Good thing somebody's awake.
Updated
Attachment #9027847 - Attachment is obsolete: true
Keywords: checkin-needed
Attachment #9028244 - Flags: review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/2a56bbf37048
remove broadcasters from common/. r=darktrojan
Status: NEW → RESOLVED
Closed: 11 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.