Closed Bug 1510351 Opened Last year Closed 5 months ago

JavaScript error: resource:///actors/PluginChild.jsm, line 998: TypeError: this.hideNotificationBar is not a function

Categories

(Core :: Plug-ins, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: timdream, Assigned: hamzah18051, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [lang=js])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1438857 +++

https://searchfox.org/mozilla-central/rev/0859e6b10fb901875c80de8f8fc33cbb77b2505e/browser/actors/PluginChild.jsm#998

This call to the removed function should be removed in the cloned bug.

I saw this error in the log from testing

browser/base/content/test/plugins/browser_globalplugin_crashinfobar.js

I wonder why the test runner didn't catch that...
Hi I would like to work on this bug!
Just to clarify should the reference to the now removed function be removed?

If no one is working on this bug then I would like to take up the issue and solve it. I'd be happy to work on it

Thanks for the patch, hamzah18051! I'm going to see if I can find someone to help you shepherd this one through.

Hi Prathiksha! You last touched the plugin infobar stuff in bug 1438857 - are you available to mentor hamzah18051 on this one?

Flags: needinfo?(prathikshaprasadsuman)
Assignee: nobody → hamzah18051
Mentor: felipc → prathikshaprasadsuman
Status: NEW → ASSIGNED
Flags: needinfo?(prathikshaprasadsuman)
Attachment #9075226 - Attachment description: Bug 1510351 - JavaScript error: resource:///actors/PluginChild.jsm, line 998: TypeError: this.hideNotificationBar is not a function → Bug 1510351 - Remove unused code in PluginChild.jsm
Pushed by prathikshaprasadsuman@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4b8c3e09e73f
Remove unused code in PluginChild.jsm r=prathiksha
Attachment #9075226 - Attachment description: Bug 1510351 - Remove unused code in PluginChild.jsm → Bug 1510351 - JavaScript error: resource:///actors/PluginChild.jsm, line 998: TypeError: this.hideNotificationBar is not a function
Attachment #9075226 - Attachment description: Bug 1510351 - JavaScript error: resource:///actors/PluginChild.jsm, line 998: TypeError: this.hideNotificationBar is not a function → Bug 1510351 - Remove unused code in PluginChild.jsm

Since the patch failed to be pushed due to the linting issues, I've submitted an updated patch. Do have a look at it

Flags: needinfo?(prathikshaprasadsuman)
Pushed by prathikshaprasadsuman@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f2781523675e
Remove unused code in PluginChild.jsm r=prathiksha
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.