1510351 - JavaScript error: resource:///actors/PluginChild.jsm, line 998: TypeError: this.hideNotificationBar is not a function

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect, P1)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #1438857 +++

https://searchfox.org/mozilla-central/rev/0859e6b10fb901875c80de8f8fc33cbb77b2505e/browser/actors/PluginChild.jsm#998

This call to the removed function should be removed in the cloned bug.

I saw this error in the log from testing

browser/base/content/test/plugins/browser_globalplugin_crashinfobar.js

I wonder why the test runner didn't catch that...

Comment 1

[Ben Armstrong]

Hi I would like to work on this bug!
Just to clarify should the reference to the now removed function be removed?

Comment 2

[Hamzah Akhtar]

If no one is working on this bug then I would like to take up the issue and solve it. I'd be happy to work on it

Comment 3

[Hamzah Akhtar]

Attachment: Bug 1510351 - Remove unused code in PluginChild.jsm

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Thanks for the patch, hamzah18051! I'm going to see if I can find someone to help you shepherd this one through.

Hi Prathiksha! You last touched the plugin infobar stuff in bug 1438857 - are you available to mentor hamzah18051 on this one?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b8c3e09e73f
Remove unused code in PluginChild.jsm r=prathiksha

Comment 6

[Razvan Maries]

Backed out for ES Lint failure.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=4b8c3e09e73f8cb7b3a70c16ab7720eba050e868&selectedJob=254451435

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=254451435&repo=autoland&lineNumber=247

Backout: https://hg.mozilla.org/integration/autoland/rev/fbf2f5bb84f816a2834eff4c776939a79076f251

Comment 7

[Hamzah Akhtar]

Since the patch failed to be pushed due to the linting issues, I've submitted an updated patch. Do have a look at it

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2781523675e
Remove unused code in PluginChild.jsm r=prathiksha

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f2781523675e