1453579 - Remove the flash infobar blocklist and related code

Status: RESOLVED FIXED

(Firefox :: General, task, P3)

Description

[:prathiksha]

Once we remove the flash infobar UI in Bug 1438857, we can use this bug to track removing the flash infobar blocklist that was added in Bug 1377036 and related code.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

(Part of this was removed in bug 1519660)

Comment 2

[:Gijs (he/him)]

Prathiksha, are you working on this?

Comment 3

[:prathiksha]

(In reply to :Gijs (he/him) from comment #2)

Prathiksha, are you working on this?

Not at the moment. Unassigning myself for now if anyone wants to work on it.

Comment 4

[disha]

(In reply to :Gijs (he/him) from comment #2)

Prathiksha, are you working on this?

Hi! I'm an Outreachy applicant and I would like to work on this issue. It would of great help if you could guide me on how I can work upon this bug.
I have my local Firefox build setup.

Comment 5

[:Gijs (he/him)]

Prathiksha, can you clarify per comment #4? I'd note that bug 1682030 has a ton of in-flight patches that might already remove this (I haven't checked).

Comment 6

[Chris Peterson [:cpeterson]]

David, do your patches for bug 1682030 ("Mass removal of NPAPI plugin code") also remove the Flash blocklist? Should this bug be resolved as a duplicate of bug 1682030?

Comment 7

[David Parks [:handyman]]

If I understand this bug correctly, it wants to remove the blocklist that was added to suppress infobar notifications about plugins from listed sites -- this was actually from Bug 1369160. Bugs linked to that one seem to study and tweak the effect but don't substantively change anything. Bug 1505913 renames browser-plugins.js to PluginParent.jsm, the parent of that JSWindowActor pair. After my patches in Bug 1682030, those JSWindowActors are reduced to only handling GMP plugin crashes.

To summarize, I believe this bug is asking to remove whatever it can from bug 1369160 and friends, but part B of that bug is already removed. The SafeBrowsing stuff from part A is fair game for removal (I haven't done it).

Bug 1377036 seems relevant only in the tests it altered in part 2 -- and those tests are already removed from the repo.

Comment 8

[BMO Automation]

Resolving as wont fix, plugin support deprecated in Firefox 85.

Comment 9

[Gregory Pappas [:gregp]]

This bug is still relevant