Closed Bug 1510500 Opened 2 years ago Closed 2 months ago

Use #ifdef in a file to declare shortcut keys in dom/xbl/builtin instead of using ShortcutKeyDefinitions.cpp per platform

Categories

(Core :: DOM: UI Events & Focus Handling, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(15 files)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
Because of the fix of bug 1419091, some shortcut keys (mainly for editor) are declared with array of C++ instead of XUL files. However, for making the review easier in the bug, platform specific shortcut keys are declared in separated ShortcutKeyDefinitions.cpp for each platform. Therefore, when I investigate shortcut keys, it's not unclear which shortcut key won't work in which platforms with synthesized key events, etc.

So, I'd like to combine them into a C++ file and using #ifdefs to enable/disable some of them only on specific platforms.
Priority: -- → P3
Component: Event Handling → User events and focus handling

Resetting assignee which I don't work on in this several months.

Assignee: masayuki → nobody
Status: ASSIGNED → NEW
Assignee: nobody → masayuki
Status: NEW → ASSIGNED

Making the following changes and future changes to the shortcut key definitions
safer, we should have a GTest for checking unexpected changes.

This will have shortcut keys definitions for the other platforms with #ifs.

Depends on D103982

For making the definitions easier to read, same definition across platforms
should be merged. For doing it and making each change review easier, we should
same things for each key group.

Depends on D103988

Attachment #9201039 - Attachment description: Bug 1510500 - part 1: Add GTest for checking no unexpected changes in r=edgar! → Bug 1510500 - part 1: Add GTest for checking no unexpected changes in `ShortcutKeyDefinitions.cpp` r=edgar!
Attachment #9201049 - Attachment description: Bug 1510500 - part 12: Group Insert key shortcut definitions r=edgar! → Bug 1510500 - part 11: Group Insert key shortcut definitions r=edgar!
Attachment #9201050 - Attachment description: Bug 1510500 - part 13: Group Delete/Backspace key shortcut definitions r=edgar! → Bug 1510500 - part 12: Group Delete/Backspace key shortcut definitions r=edgar!
Attachment #9201051 - Attachment description: Bug 1510500 - part 14: Group Accel(-Shift)-C/X/V/Z key shortcut definitions r=edgar! → Bug 1510500 - part 13: Group Accel(-Shift)-C/X/V/Z key shortcut definitions r=edgar!
Attachment #9201052 - Attachment description: Bug 1510500 - part 15: Group space key shortcut definitions r=edgar! → Bug 1510500 - part 14: Group space key shortcut definitions r=edgar!
Attachment #9201053 - Attachment description: Bug 1510500 - part 16: Group the other shortcut definitions r=edgar! → Bug 1510500 - part 15: Group the other shortcut definitions r=edgar!
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/332db3910c59
part 1: Add GTest for checking no unexpected changes in `ShortcutKeyDefinitions.cpp` r=edgar
https://hg.mozilla.org/integration/autoland/rev/82fb047175b2
part 2: Move ShortcutKeyDefinitions.cpp for Windows to XP part r=edgar
https://hg.mozilla.org/integration/autoland/rev/04ca138667bb
part 3: Move ShortcutKeyDefinitions.cpp for Linux to the XP ShortcutKeyDefinitions.cpp r=edgar
https://hg.mozilla.org/integration/autoland/rev/4da1a785ff65
part 4: Move ShortcutKeyDefinitions.cpp for Android to the XP ShortcutKeyDefinitions.cpp r=edgar
https://hg.mozilla.org/integration/autoland/rev/57910e3df62a
part 5: Move ShortcutKeyDefinitions.cpp for Emacs to the XP ShortcutKeyDefinitions.cpp r=edgar
https://hg.mozilla.org/integration/autoland/rev/f85c65d972a3
part 6: Move ShortcutKeyDefinitions.cpp for macOS to the XP ShortcutKeyDefinitions.cpp r=edgar
https://hg.mozilla.org/integration/autoland/rev/8673c1c954e6
part 7: Move all `ShortcutKeyDefinitionsFor*.h` into the XP `ShortcutKeyDefinitions.cpp` r=edgar
https://hg.mozilla.org/integration/autoland/rev/84e422db7674
part 8: Group arrow key shortcut definitions r=edgar
https://hg.mozilla.org/integration/autoland/rev/0b0a21b506b4
part 9: Group PageDown/PageUp key shortcut definitions r=edgar
https://hg.mozilla.org/integration/autoland/rev/2c28bee095f9
part 10: Group Home/End key shortcut definitions r=edgar
https://hg.mozilla.org/integration/autoland/rev/80eae543a485
part 11: Group Insert key shortcut definitions r=edgar
https://hg.mozilla.org/integration/autoland/rev/d05f359fb25c
part 12: Group Delete/Backspace key shortcut definitions r=edgar
https://hg.mozilla.org/integration/autoland/rev/c5a9cd3aef19
part 13: Group Accel(-Shift)-C/X/V/Z key shortcut definitions r=edgar
https://hg.mozilla.org/integration/autoland/rev/c5cd3697e6d8
part 14: Group space key shortcut definitions r=edgar
https://hg.mozilla.org/integration/autoland/rev/7da855a143d6
part 15: Group the other shortcut definitions r=edgar
You need to log in before you can comment on or make changes to this bug.