Open Bug 1510500 Opened 2 years ago Updated 1 year ago

Use #ifdef in a file to declare shortcut keys in dom/xbl/builtin instead of using ShortcutKeyDefinitions.cpp per platform

Categories

(Core :: DOM: UI Events & Focus Handling, enhancement, P3)

Product:
Core
Component:
DOM: UI Events & Focus Handling
Type:
enhancement

Tracking

()

Status:
ASSIGNED

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Because of the fix of bug 1419091, some shortcut keys (mainly for editor) are declared with array of C++ instead of XUL files. However, for making the review easier in the bug, platform specific shortcut keys are declared in separated ShortcutKeyDefinitions.cpp for each platform. Therefore, when I investigate shortcut keys, it's not unclear which shortcut key won't work in which platforms with synthesized key events, etc.

So, I'd like to combine them into a C++ file and using #ifdefs to enable/disable some of them only on specific platforms.
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.