1510711 - GeckoView doesn't have branding assets in omnijar

Status: RESOLVED FIXED

(GeckoView :: General, defect, P3)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

It seems like this should be working, but it doesn't. Some tests rely on about:logo working, otherwise I don't know if we would care.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

It seems like this is likely some build system stuff going wrong. Nick, any ideas?

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

This causes dom/html/test/test_bug694503.html to fail, and maybe others.

Comment 3

[Nick Alexander :nalexander [he/him]]

Looking at

https://queue.taskcluster.net/v1/task/DRHUgBTtQFCd1PjPchBgqA/runs/0/artifacts/public/build/target.apk

I see

assets/omni.ja:chrome/chrome/content/branding/about.png

However, looking at

https://queue.taskcluster.net/v1/task/DRHUgBTtQFCd1PjPchBgqA/runs/0/artifacts/public/android/maven/org/mozilla/geckoview/geckoview-default-armeabi-v7a/65.0.20181128171153/geckoview-default-armeabi-v7a-65.0.20181128171153.aar

I see no such entries.

And indeed, I see in 

https://searchfox.org/mozilla-central/rev/f2028b4c38bff2a50ed6aa1763f6dc5ee62b0cc4/mobile/android/chrome/jar.mn#51

the entry:

% content branding %content/branding/

However, looking at

https://searchfox.org/mozilla-central/rev/f2028b4c38bff2a50ed6aa1763f6dc5ee62b0cc4/mobile/android/chrome/geckoview/jar.mn

I see no such entry.

Presumably we need to add branding for GV (channel-specific?), perhaps at mobile/android/branding/geckoview (to follow suit with chrome/geckoview, etc), and either set MOZ_BRANDING_DIRECTORY (tricky) or add the proper entry to geckoview/jar.mn (easier, I expect).

snorp: can you connect this discussion to a person who knows what the GV internal branding bits should be?  The technical path forward is clear.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1510711 - Make Fennec branding (about:logo, etc) available in GeckoView

Comment 5

[Chris Peterson [:cpeterson]]

65=wontfix because we don't need to uplift these Fennec assets if they are only needed for tests.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ceb0427f883
Make Fennec branding (about:logo, etc) available in GeckoView r=geckoview-reviewers,agi

Comment 7

[Cosmin Sabou [:CosminS]]

Backed out for Android mochitest failures on testJarReader.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=7ceb0427f883d038bcca141a502845ce6eb92e1b&tochange=d8deeeb37952ad156be7468e44eaa990092328e8&selectedJob=218869012&searchStr=android%2C4.3%2Capi16%2B%2Copt%2Cmochitests%2Ctest-android-em-4.3-arm7-api-16%2Fopt-robocop-2%2Cm%28rc2%29

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=218869012&repo=autoland&lineNumber=1417

Backout link: https://hg.mozilla.org/integration/autoland/rev/d8deeeb37952ad156be7468e44eaa990092328e8

task 2018-12-26T21:02:09.619Z] 21:02:09     INFO -  TEST-PASS | testJarReader | getPackageResourcePath is non-null - /data/app/org.mozilla.fennec_aurora-1.apk should not equal null
[task 2018-12-26T21:02:09.619Z] 21:02:09     INFO -  Buffered messages finished
[task 2018-12-26T21:02:09.620Z] 21:02:09  WARNING -  TEST-UNEXPECTED-FAIL | testJarReader | JarReader returned non-null for valid file in valid jar - didn't expect null, but got it
[task 2018-12-26T21:02:19.838Z] 21:02:19     INFO -  0 ERROR Exception caught during test! - junit.framework.AssertionFailedError: TEST-UNEXPECTED-FAIL | testJarReader | JarReader returned non-null for valid file in valid jar - didn't expect null, but got it
[task 2018-12-26T21:02:19.839Z] 21:02:19     INFO -  	at junit.framework.Assert.fail(Assert.java:50)
[task 2018-12-26T21:02:19.840Z] 21:02:19     INFO -  	at org.mozilla.gecko.FennecMochitestAssert._logMochitestResult(FennecMochitestAssert.java:124)
[task 2018-12-26T21:02:19.841Z] 21:02:19     INFO -  	at org.mozilla.gecko.FennecMochitestAssert.ok(FennecMochitestAssert.java:145)
[task 2018-12-26T21:02:19.841Z] 21:02:19     INFO -  	at org.mozilla.gecko.FennecMochitestAssert.isnot(FennecMochitestAssert.java:155)
[task 2018-12-26T21:02:19.842Z] 21:02:19     INFO -  	at org.mozilla.gecko.tests.testJarReader.testJarReader(testJarReader.java:32)
[task 2018-12-26T21:02:19.842Z] 21:02:19     INFO -  	at java.lang.reflect.Method.invokeNative(Native Method)
[task 2018-12-26T21:02:19.842Z] 21:02:19     INFO -  	at java.lang.reflect.Method.invoke(Method.java:525)
[task 2018-12-26T21:02:19.843Z] 21:02:19     INFO -  	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
[task 2018-12-26T21:02:19.843Z] 21:02:19     INFO -  	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
[task 2018-12-26T21:02:19.843Z] 21:02:19     INFO -  	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
[task 2018-12-26T21:02:19.846Z] 21:02:19     INFO -  	at org.mozilla.gecko.tests.BaseRobocopTest.runTest(BaseRobocopTest.java:188)
[task 2018-12-26T21:02:19.846Z] 21:02:19     INFO -  	at junit.framework.TestCase.runBare(TestCase.java:134)
[task 2018-12-26T21:02:19.846Z] 21:02:19     INFO -  	at junit.framework.TestResult$1.protect(TestResult.java:115)
[task 2018-12-26T21:02:19.846Z] 21:02:19     INFO -  	at junit.framework.TestResult.runProtected(TestResult.java:133)
[task 2018-12-26T21:02:19.846Z] 21:02:19     INFO -  	at junit.framework.TestResult.run(TestResult.java:118)
[task 2018-12-26T21:02:19.846Z] 21:02:19     INFO -  	at junit.framework.TestCase.run(TestCase.java:124)
[task 2018-12-26T21:02:19.847Z] 21:02:19     INFO -  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
[task 2018-12-26T21:02:19.847Z] 21:02:19     INFO -  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
[task 2018-12-26T21:02:19.847Z] 21:02:19     INFO -  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
[task 2018-12-26T21:02:19.847Z] 21:02:19     INFO -  	at org.mozilla.gecko.FennecInstrumentationTestRunner.onStart(FennecInstrumentationTestRunner.java:66)
[task 2018-12-26T21:02:19.847Z] 21:02:19     INFO -  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91582d65479c
Make Fennec branding (about:logo, etc) available in GeckoView r=geckoview-reviewers,agi

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/91582d65479c