1517160 - Favicon missing for internal pages (about:home, about:firefox, etc.)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P2)

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Anthony, can you help find an owner for this issue? Thanks!

Comment 2

[Jan Henning [:JanH]]

This was simply broken by the changes in bug 1510711, so I don't think this needs any UX input.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Petru, is this something your team can take a look at or do you think you might need help from the geckoview team?

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Removing my NI as Vlad is now the assignee.

Comment 5

[Vlad Baicu]

I investigated the favicons but everything seems fine. Jan, is there something else left to do here ?

Comment 6

[Jan Henning [:JanH]]

Compare the favicon of about:firefox in the tabs tray in Nightly and Beta - it should be a tiny Firefox logo, but on Nightly it's currently missing and replaced by a "?" because Snorp broke it.

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

Yeah I'll take a look.

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1517160 - Use correct icon path for internal about pages r?#geckoview-reviewers

Comment 9

[Vlad Baicu]

Assigning snorp to the bug as this was in my work queue but he already put up a patch for the issue.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ba5964567a6
Use correct icon path for internal about pages r=geckoview-reviewers,esawin#geckoview-reviewers

Comment 11

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/8ba5964567a6

Comment 12

[Mike de Boer [:mikedeboer]]

https://hg.mozilla.org/projects/cedar/rev/8ba5964567a64f6a09b4de8ea4f8e8d151958f00
Bug 1517160 - Use correct icon path for internal about pages r=geckoview-reviewers,esawin#geckoview-reviewers

Comment 13

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Nightly 66.0a1 (2019-01-28), with HTC 10 (Android 8.0)
Thank you!