Closed Bug 1510961 Opened Last year Closed 8 months ago

Class Structure Warning: 'private' method declared 'final'

Categories

(GeckoView :: General, enhancement, P5)

Unspecified
Android
enhancement

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: fluffyemily, Assigned: lui.timm)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Reports methods declared final and private. As private methods cannot be meaningfully overridden, declaring them final is redundant.

Affected Classes:

GeckoLoader
GeckoRuntime
See Also: → 1510962
Keywords: good-first-bug
OS: Unspecified → Android
Priority: -- → P5
Product: Firefox for Android → GeckoView

Hi, I was thinking about taking this for my first bug. I've been looking at the two classes mentioned above but dont see them being declared both final and private. Is this still an issue or am I looking at the wrong place.. Thanks

Hi :Timm. Thanks for looking at this bug.

On GeckoLoader the affected methods are: getCPUABI, attemptLoad and doLoadLibraryExpected.
On GeckoRuntime the affected method is: getProcessName.

If you need to get up and running with GeckoView you can refer to our getting started guide here: https://mozilla.github.io/geckoview/tutorials/geckoview-quick-start.html

You can run the lint using ./mach android lint after you set up the workspace using the guide linked above.

Feel free to ask any questions here on the bug or on IRC at #mobile.

Thanks for the pointers! I'll get a start on this now, thanks.

Also can someone with the appropriate privileges assign this bug to me?

Here you go.

Assignee: nobody → lui.timm
Attached patch 1510961.patchSplinter Review
Comment on attachment 9048713 [details] [diff] [review]
1510961.patch

This looks good. Thanks :Timm
Attachment #9048713 - Flags: review+
Attachment #9048713 - Flags: checkin+
Attachment #9048713 - Flags: checkin+ → checkin?
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2f184631538
"Class Structure Warning: 'private' method declared 'final'". r=etoop

Emily, can you please remove the "checkin?" flag since the bug has landed.
Please note that if the keywords are set to "Keywords: checkin-needed", the flag should be removed automatically by the pulse bot. Thank you!

Flags: needinfo?(etoop)
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Thanks for all the help in my first open source contribution, much appreciated!

Flags: needinfo?(etoop)

Thank you very much for your contribution :Timm. We look forward to any further contributions you would like to make.

You need to log in before you can comment on or make changes to this bug.