1510961 - Class Structure Warning: 'private' method declared 'final'

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P5)

Description

[Emily Toop (:fluffyemily)]

Reports methods declared final and private. As private methods cannot be meaningfully overridden, declaring them final is redundant.

Affected Classes:

GeckoLoader
GeckoRuntime

Comment 1

[Timm]

Hi, I was thinking about taking this for my first bug. I've been looking at the two classes mentioned above but dont see them being declared both final and private. Is this still an issue or am I looking at the wrong place.. Thanks

Comment 2

[Emily Toop (:fluffyemily)]

Hi :Timm. Thanks for looking at this bug.

On GeckoLoader the affected methods are: getCPUABI, attemptLoad and doLoadLibraryExpected.
On GeckoRuntime the affected method is: getProcessName.

If you need to get up and running with GeckoView you can refer to our getting started guide here: https://mozilla.github.io/geckoview/tutorials/geckoview-quick-start.html

You can run the lint using ./mach android lint after you set up the workspace using the guide linked above.

Feel free to ask any questions here on the bug or on IRC at #mobile.

Comment 3

[Timm]

Thanks for the pointers! I'll get a start on this now, thanks.

Comment 4

[Timm]

Also can someone with the appropriate privileges assign this bug to me?

Comment 5

[[ex-Mozilla] Agi Sferro | :agi]

Here you go.

Comment 6

[Timm]

Attachment: 1510961.patch

Comment 7

[Emily Toop (:fluffyemily)]

Comment on attachment 9048713 [details] [diff] [review]
1510961.patch

This looks good. Thanks :Timm

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2f184631538
"Class Structure Warning: 'private' method declared 'final'". r=etoop

Comment 9

[Cristian Brindusan [:cbrindusan]]

Emily, can you please remove the "checkin?" flag since the bug has landed.
Please note that if the keywords are set to "Keywords: checkin-needed", the flag should be removed automatically by the pulse bot. Thank you!

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/b2f184631538

Comment 11

[Timm]

Thanks for all the help in my first open source contribution, much appreciated!

Comment 12

[Emily Toop (:fluffyemily)]

Thank you very much for your contribution :Timm. We look forward to any further contributions you would like to make.