1510962 - Class Structure Warning: 'static' method declared 'final'

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P5)

Description

[Emily Toop (:fluffyemily)]

Reports methods declared final and static. When a static method is overridden in a subclass it can still be accessed via the super class, making a final declaration not very necessary. Declaring a static method final does prevent subclasses from defining a static method with the same signature.

Affected Classes:

GeckoLoader
GeckoRuntime

Comment 1

[chanad17]

Hey! I would like to look into this bug for an assignment for university.

Comment 2

[Emily Toop (:fluffyemily)]

Hi :chanad17. This bug is available to pick up if you are interested. We usually ask first time contributors to attach a patch before assigning bugs.

If you need help setting up GeckoView, you can follow our setup guides on our documentation site: https://mozilla.github.io/geckoview/contributor/.

Feel free to use the public Riot GeckoView channel to ask questions: https://chat.mozilla.org/#/room/#geckoview:mozilla.org

Comment 3

[Chris Peterson [:cpeterson]]

Enhancements should have severity N/A.

Comment 4

[Logan Rosen [:Logan]]

Attachment: Bug 1510962 - remove unnecessary 'final' declaration r?#geckoview-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02b9987dee27
remove unnecessary 'final' declaration r=geckoview-reviewers,m_kato

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/02b9987dee27