1511053 - Dragging a tab in Windows Aero Basic causes the TabsToolbar background to change slightly

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1) Put Windows 7 into the Windows Aero Basic theme
2) Open Firefox
3) Open several tabs
4) Click and drag at least one tab

ER:

The tab toolbar background should not change

AR:

The tab toolbar background subtly changes - it gets slightly darker.


See screencapture: https://www.screencast.com/t/9sskHxVQ

mozregression says this is a regression from bug 1356920.

Comment 1

[Dão Gottwald [:dao]]

This is subtle enough that I would rank this P5, but it would go good to understand what exactly is going on here and if this could cause other problems in other settings.

Comment 2

[Dão Gottwald [:dao]]

The background is coming from here:
https://searchfox.org/mozilla-central/rev/43bf9e7c8acf042617a1ebc5d2ce540d78f0ce91/browser/themes/windows/browser.css#294-300

The background changes because this gross hack now affects #titlebar's height:
https://searchfox.org/mozilla-central/rev/43bf9e7c8acf042617a1ebc5d2ce540d78f0ce91/browser/base/content/browser.css#256-270

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1511053 - Stop affecting the titlebar's height while dragging tabs. r=Gijs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fd4818ddfce
Stop affecting the titlebar's height while dragging tabs. r=Gijs

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/7fd4818ddfce

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 9042750 [details]
Bug 1511053 - Stop affecting the titlebar's height while dragging tabs. r=Gijs

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: bug 1356920
• User impact if declined: see coment 0. bug 1521803 appears to be another symptom of this bug.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: see comment 0. Should also verify that this doesn't regress bug 450915.
• List of other uplifts needed: /
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This code (which goes back to bug 450915) was a bit nonsensical and this basically cleans it up. As far as bug 450915 is concerned it should behave the same. Has baked in Nightly for two weeks.
• String changes made/needed: /

Comment 7

[laszlo.bialis]

Hi,

I've managed to reproduce the issue above as seen on the attached screen capture, on Nightly 65.0a1 20181130093534 only on win 7 x32 (I couldn't reproduce it on on x64 ) using a Win 7 base color theme (non Aero).

I've also checked on the latest Nightly 67.0a1 20190225102402, on the same system (win7 x32) and the issue is fixed now. Marking as verified on Nightly.

Will check after it will be uplifted on Beta also.

Comment 8

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 9042750 [details]
Bug 1511053 - Stop affecting the titlebar's height while dragging tabs. r=Gijs

Minor cleanup, not urgent but it looks pretty safe and fixes several other issues.
OK for uplift for beta 12.

Comment 9

[Razvan Maries]

https://hg.mozilla.org/releases/mozilla-beta/rev/370feb072937

Comment 10

[laszlo.bialis]

Checked the above issue again and can confirm that it is not reproducible on Win 7 x32 on Beta 66.0b12. Marking as Verified.