1511231 - PointerEvent.getCoalescedEvents return empty when using pen input and while the pointer is down

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[Qijin Zhou (Microsoft)]

Attachment: index.html

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0

Steps to reproduce:

1. Navigate to https://qijinz.github.io/getCoalescedEvents_bug or load the attached file.
2. Draw in the red canvas with a pen input.


Actual results:

Can't draw. Only draw scratches.

e.getCoalescedEvents() on a pointermove event returns an empty list.


Expected results:

Draws. It works when using mouse input.

e.getCoalescedEvents() on a pointermove event should return at least one coalesced event (worst case the fired pointermove event itself should be returned).

Comment 1

[Henri Sivonen (:hsivonen)]

smaug, should this be P2 instead?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

pen is rarely used, hard to see why this would need to be p2.

Comment 3

[Henri Sivonen (:hsivonen)]

(In reply to Olli Pettay [:smaug] (high review load) from comment #2)
> pen is rarely used, hard to see why this would need to be p2.

Thanks. It wasn't clear to me what the extent of breakage is when pen *is* used.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

It came up in our partner channel, so flagging for webcompat prioritization.

Comment 5

[Firefox Bug Husbandry Bot]

See bug 1547409. Moving webcompat whiteboard tags to project flags.

Comment 6

[Mike Taylor [:miketaylr]]

https://wpt.fyi/results/pointerevents/extension/pointerevent_getCoalescedEvents_when_pointerlocked.html?label=master&label=experimental

Comment 7

[Edgar Chen [:edgar]]

Attachment: Bug 1511231 - Part 1: Remove unused constructor from WidgetPointerEvent;

Comment 8

[Edgar Chen [:edgar]]

Attachment: Bug 1511231 - Part 2: Make PointerEventHandler::InitPointerEventFromTouch take references;

Depends on D122588

Comment 9

[Edgar Chen [:edgar]]

Attachment: Bug 1511231 - Part 3: Expose coalesced Touches to PointerEvent.getCoalescedEvents();

Depends on D122589

Comment 10

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=9daa65828848441434265af7068ea56d8dec5ffc

Comment 11

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&revision=9d1f1a9317cfb99390701f807a6662950a9becc3&group_state=expanded

Comment 12

[Edgar Chen [:edgar]]

Attachment: Bug 1511231 - Part 4: s/ProcessPendingColaescedTouchData/ProcessPendingCoalescedTouchData/; r=smaug

Depends on D122590

Comment 13

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&revision=b524eb1903abb376eb01ad4388daf9e666a0c491&group_state=expanded

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa0e4e205617
Part 1: Remove unused constructor from WidgetPointerEvent; r=smaug
https://hg.mozilla.org/integration/autoland/rev/bc913eaeeff2
Part 2: Make PointerEventHandler::InitPointerEventFromTouch take references; r=smaug
https://hg.mozilla.org/integration/autoland/rev/94a5ef68aac3
Part 3: Expose coalesced Touches to PointerEvent.getCoalescedEvents(); r=smaug
https://hg.mozilla.org/integration/autoland/rev/79dc991bfa6c
Part 4: s/ProcessPendingColaescedTouchData/ProcessPendingCoalescedTouchData/; r=smaug

Comment 15

[Alexandru Michis [:malexandru]]

Backed out 4 changesets (Bug 1511231) for causing cpp bustages in CoalescedTouchData.cpp
Backout link: https://hg.mozilla.org/integration/autoland/rev/d17f970d6b32ba9d61ccc10e14f814eca4e3b0a9
Push with failures, failure log.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a63bbff6fa40
Part 1: Remove unused constructor from WidgetPointerEvent; r=smaug
https://hg.mozilla.org/integration/autoland/rev/12cdf37e494f
Part 2: Make PointerEventHandler::InitPointerEventFromTouch take references; r=smaug
https://hg.mozilla.org/integration/autoland/rev/4882bffd97f8
Part 3: Expose coalesced Touches to PointerEvent.getCoalescedEvents(); r=smaug
https://hg.mozilla.org/integration/autoland/rev/51c88c4d63a9
Part 4: s/ProcessPendingColaescedTouchData/ProcessPendingCoalescedTouchData/; r=smaug

Comment 17

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/a63bbff6fa40
https://hg.mozilla.org/mozilla-central/rev/12cdf37e494f
https://hg.mozilla.org/mozilla-central/rev/4882bffd97f8
https://hg.mozilla.org/mozilla-central/rev/51c88c4d63a9