The coalesced touchmove event isn't updated to last status
Categories
(Core :: DOM: UI Events & Focus Handling, defect, P1)
Tracking
()
People
(Reporter: edgar, Assigned: edgar)
References
Details
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
We update the coalesced touchmove event when the touch is "changed", https://searchfox.org/mozilla-central/rev/8f08c21f093be1c1c42438697f8bca67af94fc77/dom/ipc/CoalescedTouchData.cpp#31-35.
But the "changed" information isn't propagated through IPC, https://searchfox.org/mozilla-central/rev/8f08c21f093be1c1c42438697f8bca67af94fc77/widget/nsGUIEventIPC.h#336-356
|
Assignee | |
Comment 1•3 years ago
|
||
So the coalesced touchmove event could be up-to-date
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
|
Assignee | |
Comment 3•3 years ago
|
||
|
||
Updated•3 years ago
|
Pushed by echen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fd8ffa7ed65a Make coalesced touchmove event could be up-to-date; r=smaug,sefeng
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 6•3 years ago
|
||
[Tracking Requested - why for this release]:
It is a regression of touch event coalescing.
And touch event coalescing is enabled in bug 1720200 on 92.
|
|
Assignee | |
Comment 7•3 years ago
|
||
Comment on attachment 9236076 [details]
Bug 1725493 - Make coalesced touchmove event could be up-to-date;
Beta/Release Uplift Approval Request
- User impact if declined: The state of touches might not be accurate.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce: None
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): We just update the state of touches unconditionally, there can't be too many touches, so it shouldn't be a performance issue.
- String changes made/needed: None
|
||
Updated•3 years ago
|
|
||
Comment 8•3 years ago
|
||
Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See What Do You Triage for more information
|
|
||
Comment 9•3 years ago
|
||
Comment on attachment 9236076 [details]
Bug 1725493 - Make coalesced touchmove event could be up-to-date;
Approved for 92.0b6.
|
|
||
Comment 10•3 years ago
|
||
| bugherder uplift | ||
Description
•