1725493 - The coalesced touchmove event isn't updated to last status

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P1)

Description

[Edgar Chen [:edgar]]

We update the coalesced touchmove event when the touch is "changed", https://searchfox.org/mozilla-central/rev/8f08c21f093be1c1c42438697f8bca67af94fc77/dom/ipc/CoalescedTouchData.cpp#31-35.
But the "changed" information isn't propagated through IPC, https://searchfox.org/mozilla-central/rev/8f08c21f093be1c1c42438697f8bca67af94fc77/widget/nsGUIEventIPC.h#336-356

Comment 1

[Edgar Chen [:edgar]]

Attachment: Bug 1725493 - Make coalesced touchmove event could be up-to-date;

So the coalesced touchmove event could be up-to-date

Comment 2

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=baad9fa8350eee008d15f22a23860c662fa1ee43

Comment 3

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=40dc6448e2be9c578c4e36ddaa9ce1e559010e06

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd8ffa7ed65a
Make coalesced touchmove event could be up-to-date; r=smaug,sefeng

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/fd8ffa7ed65a

Comment 6

[Edgar Chen [:edgar]]

[Tracking Requested - why for this release]:

It is a regression of touch event coalescing.
And touch event coalescing is enabled in bug 1720200 on 92.

Comment 7

[Edgar Chen [:edgar]]

Comment on attachment 9236076 [details]
Bug 1725493 - Make coalesced touchmove event could be up-to-date;

Beta/Release Uplift Approval Request

• User impact if declined: The state of touches might not be accurate.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: None
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We just update the state of touches unconditionally, there can't be too many touches, so it shouldn't be a performance issue.
• String changes made/needed: None

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See What Do You Triage for more information

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9236076 [details]
Bug 1725493 - Make coalesced touchmove event could be up-to-date;

Approved for 92.0b6.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c126e438c2cc