1511312 - Fix update tests to set "app.update.disabledForTesting" to False

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, enhancement, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

With bug 1508726 application updates are disabled with "app.update.disabledForTesting" set to True. To allow update tests to continue to work this preference has to be set to False.

Note that this also needs bug 1511311 to be fixed first.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Attachment: Bug 1511312 - [fxui] Re-enable update permissions for update tests. r?ato

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dafa583b9dfb
[fxui] Re-enable update permissions for update tests. r=ato

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/dafa583b9dfb

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Please uplift this test-only patch to beta.

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4449dde0dd98

Comment 6

[Robert Strong (they/them - no direct email)]

FYI: we're planning on removing the old UI during the next cycle.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Thanks for the heads-up. I will keep an eye on bug 1515484. Basically the tests should continue to work, unless some new ui is added. And the only necessary work for us would be to remove the old code afterward. But that is very low priority those days.

Comment 8

[Robert Strong (they/them - no direct email)]

You should be able to check by removing the app.update.doorhanger pref or setting it to true since setting that to false is what turns on the old UI.
https://searchfox.org/mozilla-central/source/testing/firefox-ui/harness/firefox_ui_harness/runners/update.py#18

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

We never implemented the doorhanger. All update tests are actually running against the about window. I assume with bug 1515484 you only remove the old software update window, but not the update functionality from the about window?

Comment 10

[Robert Strong (they/them - no direct email)]

That is correct and I'll also be removing the app.update.doorhanger pref which you added so the tests can run against the old update UI. Since you aren't using the old Update UI you should remove that pref to make certain your tests aren't relying on it in some way.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Lets move further discussion (if necessary) over to bug 1552771. Thanks.