1511345 - Add-ons not working in Nightly

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Axel Hecht [:Pike]]

None of my add-ons work in Nightly, on both my profiles.

I see 

Error: Unknown webextension type webextension 9 XPIProvider.jsm:1635:17

in the console.

Aswan, can this be fall-out from bug 857456?

Gecko Profiler and uBlock Origin are examples I have locally.

Comment 1

[Jonas Jenwald [:Snuffleupagus]]

Probably caused by a typo at https://hg.mozilla.org/mozilla-central/rev/061b97e02ede#l4.64 since I'm assuming that it should read "webextension" with one "b", and not two :-)

Comment 2

[Julien Cristau [:jcristau]]

Nightly updates disabled.

Comment 3

[Jorg K (CEST = GMT+2)]

You could just fix the typo and see whether it makes a difference.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Clearing we're missing important test coverage here too.

Comment 5

[Kris Maglione [:kmag]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)
> Clearing we're missing important test coverage here too.

Maybe. In the past, we haven't tested these kinds of short-lived migrations much, though, so we don't really have any infrastructure for it.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

It's not clear what the consequences of backing out bug 857456 would be for already-migrated users here. Anyway, I'm running a Try push of the typo fix to see where that gets us. Not sure if there's going to be schema-related issues with that, though?

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d318119c632cb72d1d42952e1a2f6be85649ce9

Comment 7

[nsdragon]

I just got hit by this after updating and restarting Nightly. But!

One of my affected extensions was Stylus, but a few minutes after restarting, Stylus was updated to a new version, and then it started working again.

I also found that by uninstalling and reinstalling a given extension, it'd also work again.

I feel like a quick workaround would be to force-update an extension (since uninstalling/reinstalling causes it to lose saved settings and such), but apparently the UI only lets me check if an update is available. Is there a way to do forced updates somehow as a temporary measure?

Comment 8

[Ronan Jouchet]

I confirm the bug and @nsdragon's remark that reinstalling/upgrading an extension makes it work again.

Nightly 65.0a1 (2018-11-30) (64-bit, Ubuntu Linux 18.04.1LTS)

Comment 9

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Downgrading to latest Firefox without this issue ( https://archive.mozilla.org/pub/firefox/nightly/2018/11/2018-11-29-21-44-05-mozilla-central/ ) is also next workaround.

Comment 10

[Kris Maglione [:kmag]]

(In reply to Virtual_ManPL [:Virtual] - (please needinfo? me - so I will see your comment/reply/question/etc.) from comment #9)
> Downgrading to latest Firefox without this issue (
> https://archive.mozilla.org/pub/firefox/nightly/2018/11/2018-11-29-21-44-05-
> mozilla-central/ ) is also next workaround.

That's not a great idea. We don't support reverse data migrations, and downgrading risks causing corruption.

Comment 11

[nsdragon]

Well now all my addons are working again without any further intervention (just another restart of the browser). I had only reinstalled maybe 1/5th of my addons; the rest of them weren't working at all until I restarted.

Was there a nightly update in the past 45 minutes? Not sure where the right place to check the full build date is, but about:buildconfig for me points to a revision made 7 hours ago.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

No, there haven't been any new Nightlies. And updates are currently frozen to the prior build rather than today's.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

For those who can reproduce, can you try of of the builds below to see if things work better? Usual caveats apply about backing up your profile, etc.

Linux64: https://queue.taskcluster.net/v1/task/ZfUb7ydXTYOMfrJg-7hMnw/runs/0/artifacts/public/build/target.tar.bz2
MacOS: https://queue.taskcluster.net/v1/task/SHdWRu3hRfS7XNIJI5VZiw/runs/0/artifacts/public/build/target.dmg
Win64: https://queue.taskcluster.net/v1/task/UZmERsn6Q46oPYttnpfM5w/runs/0/artifacts/public/build/target.zip

Comment 14

[Andrew Swan [:aswan]]

For the record, there were two issues here:
1. The typo spotted in comment 1
2. The original patch migrated extensions.json but not addonStartup.json

Those files both get rewritten when there are changes to the set of active addons, so updating or uninstalling an existing addon, or installing a new one, would cause new correct versions of those files to be written and everything would work properly after a browser restart.

With the patch from the try run above, both issues above should be fixed and both files should be properly migrated without any further user action.

Comment 15

[Ronan Jouchet]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #13)
> For those who can reproduce, can you try of of the builds below to see if
> things work better? Usual caveats apply about backing up your profile, etc.
> 
> Linux64:
> https://queue.taskcluster.net/v1/task/ZfUb7ydXTYOMfrJg-7hMnw/runs/0/
> artifacts/public/build/target.tar.bz2

This build fixed it for me, all my addons are back in my toolbar and active.
Using Ubuntu Linux 18.04.1LTS.

Comment 16

[Andrew Swan [:aswan]]

Attachment: Bug 1511345 Fix migration from bug 857456 r=kmag

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/bb2815518fc7
Fix migration from bug 857456. r=kmag, r=zombie, a=RyanVM

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/b1446de2dd13
Follow-up: Don't blow up on empty addonStartup.json r=zombie a=RyanVM

Comment 20

[Ryan VanderMeulen [:RyanVM]]

New nightlies are currently being built and updates will be re-enabled once they're finished. Builds with Build ID of 20181130191449 or newer should contain the fix.

Comment 21

[Jules A]

Reddit Enhancemnt Suite, HTTPS Everywhere and Decentraleyes are still not working, maybe even more but uBlock seems to be working fine.

Comment 22

[Jules A]

Forgot to mention I'm using build 20181130200939.

Comment 23

[Andrew Swan [:aswan]]

(In reply to Jules A from comment #21)
> Reddit Enhancemnt Suite, HTTPS Everywhere and Decentraleyes are still not
> working, maybe even more but uBlock seems to be working fine.

If you're still having problems, please open a separate bug and include more detail about exactly what isn't working.

Comment 24

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to Kris Maglione [:kmag] from comment #10)
> (In reply to Virtual_ManPL [:Virtual] - (please needinfo? me - so I will see
> your comment/reply/question/etc.) from comment #9)
> > Downgrading to latest Firefox without this issue (
> > https://archive.mozilla.org/pub/firefox/nightly/2018/11/2018-11-29-21-44-05-
> > mozilla-central/ ) is also next workaround.
> 
> That's not a great idea. We don't support reverse data migrations, and
> downgrading risks causing corruption.

True, but it thankfully worked in my case without any negative effects and profile wasn't damaged, but like always I had backup close at hand.

(In reply to Jules A from comment #21)
> Reddit Enhancemnt Suite, HTTPS Everywhere and Decentraleyes are still not
> working, maybe even more but uBlock seems to be working fine.

In my case Decentraleyes working fine, as other extensions like:
- CanvasBlocker 0.5.5
- Cookie AutoDelete 2.2.0
- CSS Exfil Protection 1.0.11
- Decentraleyes 2.0.8
- Disable HTML5 Autoplay 2018.10.3
- Don't touch my tabs! (rel=noopener) 2.1
- Don't track me Google 4.21
- Download Star 2.0.2
- Firefox Pioneer 1.0
- uBlock Origin 1.17.3.105
working fine, so I'm confirming that bug is fixed in latest Nightly and I'm marking this bug as VERIFIED. Thank you very much. \o/

Comment 25

[Jules A]

Oddly enough resetting extensions.databaseSchema pref fixed it for me.