stop supporting install.rdf

REOPENED
Unassigned

Status

()

REOPENED
6 years ago
a month ago

People

(Reporter: Unfocused, Unassigned)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Currently, the Add-ons Manager uses nsIRDFService to read install.rdf - we'd like to kill that with fire. However, we can't just drop support for install.rdf. Instead, I'd like to move to using the RDF reader JSM that bug 857454 will implement.
Depends on: 357276
No longer depends on: 857454
Blocks: 833098

Updated

2 years ago
Summary: Use RDF reader module for reading install.rdf manifests → Use RDF reader module for reading install.rdf manifests, or convert them to JSON

Comment 1

a year ago
:mak, it seems like we can close this now that we only support web extensions. Is that correct?
Flags: needinfo?(mak77)
We still support legacy extensions (which use install.rdf) for things like system addons and extensions used in automation.  Switching these over to json so we can ditch rdf would be a fine thing but there are a lot of pieces to update.
Flags: needinfo?(mak77)

Comment 3

a year ago
(In reply to Andrew Swan [:aswan] from comment #2)
> We still support legacy extensions (which use install.rdf) for things like
> system addons and extensions used in automation.  Switching these over to
> json so we can ditch rdf would be a fine thing but there are a lot of pieces
> to update.

Do we have a list somewhere? How long do we plan on supporting them?
(In reply to Eric Rahm [:erahm] (please no mozreview requests) from comment #3)
> (In reply to Andrew Swan [:aswan] from comment #2)
> > We still support legacy extensions (which use install.rdf) for things like
> > system addons and extensions used in automation.  Switching these over to
> > json so we can ditch rdf would be a fine thing but there are a lot of pieces
> > to update.
> 
> Do we have a list somewhere? How long do we plan on supporting them?

I don't mean this to be cheeky but I would start with something like:
http://searchfox.org/mozilla-central/search?q=&case=false&regexp=false&path=install.rdf

Off the top of my head, test pilot and devtools are the other big users of legacy extensions.

This has sort of been in the background for a while but folks working on addons have had a lot of other things in front of us.  Now that 57 is mostly done we can come back to things like this.  Just out of curiosity, is there something other than a general desire to get rid of old cruft that brought this to the foreground right now?

Comment 5

a year ago
(In reply to Andrew Swan [:aswan] from comment #4)
> (In reply to Eric Rahm [:erahm] (please no mozreview requests) from comment
> #3)
> > (In reply to Andrew Swan [:aswan] from comment #2)
> > > We still support legacy extensions (which use install.rdf) for things like
> > > system addons and extensions used in automation.  Switching these over to
> > > json so we can ditch rdf would be a fine thing but there are a lot of pieces
> > > to update.
> > 
> > Do we have a list somewhere? How long do we plan on supporting them?
> 
> I don't mean this to be cheeky but I would start with something like:
> http://searchfox.org/mozilla-central/
> search?q=&case=false&regexp=false&path=install.rdf

That's reasonable! Looks like we have quite a few (even ignoring tests).

> This has sort of been in the background for a while but folks working on
> addons have had a lot of other things in front of us.  Now that 57 is mostly
> done we can come back to things like this.  Just out of curiosity, is there
> something other than a general desire to get rid of old cruft that brought
> this to the foreground right now?

I'm trying to revive the removal of RDF (which I get is probably low priority). It seems like adding a shim for parsing add-on install manifests might be the easiest route or I guess adding json support and some sort of automated conversion.
(In reply to Eric Rahm [:erahm] (please no mozreview requests) from comment #5)
> I'm trying to revive the removal of RDF (which I get is probably low
> priority). It seems like adding a shim for parsing add-on install manifests
> might be the easiest route or I guess adding json support and some sort of
> automated conversion.

I'd vote for just getting rid of it completely.  The very crude outline is of course:
1. Offer a json alternative
2. Convert existing users over
3. Rip out the rdf support

I don't think #1 will be too tough, let me see if I can crank something out to get the ball rolling.
As per bug 357276
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → WONTFIX
No longer blocks: 833098

Comment 8

10 months ago
While we won't get a reader, install.rdf is far from being gone:
https://searchfox.org/mozilla-central/search?q=install.rdf&path=

It's true now we don't support legacy add-ons by default, but still the situation doesn't allow to remove rdf code.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Summary: Use RDF reader module for reading install.rdf manifests, or convert them to JSON → stop supporting install.rdf

Updated

10 months ago
Blocks: 833098

Updated

8 months ago
Depends on: 1449052

Updated

7 months ago
Depends on: 1452330

Comment 9

7 months ago
Update: we have removed a bunch of addon types that used install.rdf.  The two remaining are dictionaries and bootstrapped extensions.  Rather than changing from install.rdf to a JSON format as suggested in comment 6, we will remove support for both of these extension types (in favor of WebExtension-based alternatives).  The dependencies on this bug cover that effort.
Depends on: 1410214
No longer depends on: 1452330

Updated

7 months ago
No longer blocks: 833098

Updated

3 months ago
Blocks: 1460180

Updated

3 months ago
Blocks: 1347507
No longer blocks: 1460180
You need to log in before you can comment on or make changes to this bug.