Closed Bug 1511352 Opened 6 years ago Closed 6 years ago

Update Debugger Frontend v106

Categories

(DevTools :: Debugger, defect)

Product:
DevTools
Component:
Debugger
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox65 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file)

106-1.patch
218.07 KB, patch
davidwalsh
: review+
Details | Diff | Splinter Review
No longer blocks: 1510948
No longer depends on: 1510629
Attached patch 106-1.patch — — Splinter Review
Assignee: nobody → jlaster
Attachment #9028925 - Flags: review?(dwalsh)
Comment on attachment 9028925 [details] [diff] [review] 106-1.patch R+ functionality; waiting on Try to checkin-needed.
Attachment #9028925 - Flags: review?(dwalsh) → review+
Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/91e1fe27cef9 Update Debugger Frontend v106. r=dwalsh
Backout by ccoroiu@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/a00c3f230203 Backed out changeset 91e1fe27cef9 for causing merge conflicts with bug 820878 a=backout
Backed out changeset 91e1fe27cef9 (bug 1511352) for causing merge conflicts with bug 820878 a=backout This happened while merging inbound to central. Backout link: https://hg.mozilla.org/mozilla-central/rev/a00c3f230203 Console output: ccoroiu@ubuntu ~/mozilla-unified central(0) $ hg merge -r 94ef0a404e40 merging devtools/client/debugger/new/dist/debugger.css merging devtools/client/shared/components/reps/reps.js merging js/src/gc/Zone.cpp merging js/src/jit/BaselineIC.h merging js/src/jit/BaselineJIT.cpp merging netwerk/base/nsIOService.cpp merging netwerk/base/nsSocketTransport2.cpp merging netwerk/protocol/http/nsHttp.h merging netwerk/protocol/http/nsHttpChannel.cpp merging netwerk/protocol/http/nsHttpConnectionInfo.cpp merging netwerk/protocol/http/nsHttpConnectionInfo.h merging netwerk/protocol/http/nsHttpConnectionMgr.cpp merging netwerk/protocol/viewsource/nsViewSourceChannel.cpp warning: conflicts while merging devtools/client/shared/components/reps/reps.js! (edit, then use 'hg resolve --mark') 2410 files updated, 12 files merged, 1 files removed, 1 files unresolved use 'hg resolve' to retry unresolved file merges or 'hg update -C .' to abandon
Flags: needinfo?(jlaster)
looks like we had a lando / inbound midair collision. Here's a try run with some fixups https://treeherder.mozilla.org/#/jobs?repo=try&revision=a16ec72cc2198a93baeb605e574e04eb92a95cd2
Flags: needinfo?(jlaster)
Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/da85232375a0 Update Debugger Frontend v106. r=dwalsh
https://hg.mozilla.org/mozilla-central/rev/da85232375a0
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
This release had quite dramatic impact on performance of the debugger :/ == Change summary for alert #17961 (as of Fri, 30 Nov 2018 14:22:02 GMT) == Regressions: 875% damp custom.jsdebugger.stepIn.DAMP windows10-64 pgo e10s stylo 1,249.71 -> 12,186.24 653% damp custom.jsdebugger.stepIn.DAMP linux64-qr opt e10s stylo 1,263.76 -> 9,522.29 442% damp custom.jsdebugger.stepIn.DAMP osx-10-10 opt e10s stylo 2,055.19 -> 11,132.85 90% damp complicated.jsdebugger.open.DAMP windows10-64 pgo e10s stylo 1,357.41 -> 2,578.22 63% damp complicated.jsdebugger.reload.DAMP windows10-64 pgo e10s stylo 1,886.96 -> 3,084.76 60% damp complicated.jsdebugger.open.DAMP linux64-qr opt e10s stylo 1,568.76 -> 2,516.82 59% damp complicated.jsdebugger.open.DAMP osx-10-10 opt e10s stylo 2,904.11 -> 4,604.97 52% damp complicated.jsdebugger.reload.DAMP osx-10-10 opt e10s stylo 4,486.03 -> 6,832.80 49% damp complicated.jsdebugger.reload.DAMP linux64-qr opt e10s stylo 2,073.69 -> 3,094.83 29% damp custom.jsdebugger.stepOut.DAMP osx-10-10 opt e10s stylo 1,493.73 -> 1,932.24 7% damp console.objectexpand windows10-64 opt e10s stylo 409.27 -> 436.23 6% damp console.objectexpand windows10-64-qr opt e10s stylo 410.62 -> 435.31 6% damp console.objectexpand windows10-64 pgo e10s stylo 376.37 -> 398.65 6% damp console.objectexpand windows7-32 opt e10s stylo 391.26 -> 414.32 6% damp console.objectexpand windows7-32 pgo e10s stylo 361.72 -> 382.99 6% damp console.objectexpand linux64 pgo e10s stylo 364.90 -> 385.31 5% damp windows10-64 pgo e10s stylo 216.30 -> 227.26 5% damp console.objectexpand linux64-qr opt e10s stylo 410.98 -> 431.64 5% damp linux64-qr opt e10s stylo 239.82 -> 251.29 5% damp console.objectexpand linux64 opt e10s stylo 408.30 -> 426.77 3% damp custom.jsdebugger.stepOver.DAMP windows10-64 pgo e10s stylo 306.91 -> 315.38 Improvements: 21% damp complicated.jsdebugger.close.DAMP osx-10-10 opt e10s stylo 136.71 -> 107.91 8% damp custom.jsdebugger.stepOut.DAMP windows7-32 pgo e10s stylo 839.55 -> 775.38 8% damp custom.jsdebugger.stepOut.DAMP windows10-64 pgo e10s stylo 840.82 -> 776.76 3% damp complicated.styleeditor.open.DAMP windows10-64 pgo e10s stylo 751.99 -> 726.13 For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=17961
Blocks: 1513397
alright another try which just reverts what i believe is the slow commit https://treeherder.mozilla.org/#/jobs?repo=try&revision=72b5b50cd89f1d0d61a226bb9e91c68342c8476e
No longer blocks: 1513397
Blocks: 1513737
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: