Closed
Bug 1511889
Opened 7 years ago
Closed 7 years ago
LoadLibraryUsageChecker is broken on clang trunk
Categories
(Developer Infrastructure :: Source Code Analysis, enhancement)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox65 fixed)
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: tjr, Assigned: andi)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
As seen in this try push: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=214389998&revision=d6ca715767e52bef777d7987399c32448cb1753d the LoadLibraryUsageChecker is broken on clang trunk.
In Bug 1485016 we might consider bumping to clang trunk to get guard:cf support (undetermined).
Andi - what's a possible solution here? I presume it's possible to build a clang-plugin that uses some #if's to have a slightly different code path for different clang versions?
|
Assignee | |
Updated•7 years ago
|
Flags: needinfo?(bpostelnicu)
|
|
Assignee | |
Comment 1•7 years ago
|
||
This should be straight forward since in Bug 1501821 I did the implementation on how we can support clang 8.0 - trunk. I will push a patch.
Flags: needinfo?(bpostelnicu)
|
|
Assignee | |
Comment 2•7 years ago
|
||
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → bpostelnicu
|
|
Assignee | |
Comment 3•7 years ago
|
||
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/335e8f4298ce
Update clang-plugin LoadLibraryUsageChecker to use getBeginLoc. r=froydnj
|
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
|
||
Updated•7 years ago
|
Target Milestone: Firefox 65 → mozilla65
|
||
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•