Closed Bug 1511889 Opened Last year Closed Last year

LoadLibraryUsageChecker is broken on clang trunk

Categories

(Firefox Build System :: Source Code Analysis, enhancement)

enhancement
Not set

Tracking

(firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: tjr, Assigned: andi)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

As seen in this try push: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=214389998&revision=d6ca715767e52bef777d7987399c32448cb1753d the LoadLibraryUsageChecker is broken on clang trunk.  

In Bug 1485016 we might consider bumping to clang trunk to get guard:cf support (undetermined).

Andi - what's a possible solution here? I presume it's possible to build a clang-plugin that uses some #if's to have a slightly different code path for different clang versions?
Flags: needinfo?(bpostelnicu)
This should be straight forward since in Bug 1501821  I did the implementation on how we can support clang 8.0 - trunk. I will push a patch.
Flags: needinfo?(bpostelnicu)
Assignee: nobody → bpostelnicu
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/335e8f4298ce
Update clang-plugin LoadLibraryUsageChecker to use getBeginLoc. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/335e8f4298ce
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Target Milestone: Firefox 65 → mozilla65
You need to log in before you can comment on or make changes to this bug.