Closed
Bug 1512037
Opened 6 years ago
Closed 5 years ago
Crash in java.lang.NoClassDefFoundError: at org.mozilla.gecko.GeckoSystemStateListener.prefersReducedMotion(GeckoSystemStateListener.java)
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Tracking
(geckoview64 fixed, firefox64 verified, firefox65 verified, firefox66 verified)
VERIFIED
FIXED
Firefox 66
People
(Reporter: gsvelto, Assigned: hiro)
References
Details
(Keywords: crash, reproducible, Whiteboard: [geckoview:p1])
Crash Data
Attachments
(1 file)
|
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
jcristau
:
approval-mozilla-release+
|
Details | Review |
This bug was filed from the Socorro interface and is report bp-c602ad5e-1557-4fda-be90-fed8e0181204. ============================================================= Java stack trace: java.lang.NoClassDefFoundError at org.mozilla.gecko.GeckoSystemStateListener.prefersReducedMotion(GeckoSystemStateListener.java:89) at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method) at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:466) This seems to have started with build 20181128100103.
|
||
Comment 1•5 years ago
|
||
These crashes appear to be all happening with Jelly Bean, and the crashes are also present on 64b15 - so perhaps not a regression in nightly. All of the crashes have Moz Crash Reason MOZ_CRASH(JNI exception). Comments unfortunately don't appear to be very useful.
status-firefox64:
--- → affected
status-firefox65:
--- → affected
|
||
Comment 2•5 years ago
|
||
Str: Use a HTC One X Android 4.1.1 * visit https://www.bbc.com/news Actual results: crash Expected: view website
|
|
||
Updated•5 years ago
|
Keywords: reproducible
|
|
||
Comment 3•5 years ago
•
|
||
Regression range is pre 2018-11-27. The 2018-11-28 build must have contained a fix for the crash reporter or Firefox for Android. Before this the behavior is to repeatedly crash. Flashing between the home screen and a white screen from Nightly.
|
|
||
Comment 4•5 years ago
|
||
74:00.06 INFO: Got as far as we can go bisecting nightlies... 74:00.06 INFO: Last good revision: 73a2f427e2fdd0511198a2e308c21f3b74ca7f7d (2018-09-15) 74:00.06 INFO: First bad revision: 7ed950e60f3c1f8a47c117c04124d31e94a66e32 (2018-09-16) 74:00.06 INFO: Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=73a2f427e2fdd0511198a2e308c21f3b74ca7f7d&tochange=7ed950e60f3c1f8a47c117c04124d31e94a66e32 Not much in the regression range. Maybe Bug 1449567? Snorp you reviewed it thoughts if this could be the issue. Will continue tomorrow if needed. Though this regression is tedious to debug due to phone issues. One phone cannot adb install via mozregression (manual command line is fine) and the other cannot see the WiFi networks in the office.
Flags: needinfo?(snorp)
|
||
Comment 5•5 years ago
|
||
Bug 1504780 fixed an issue with the crash reporter in the 2018-11-28 nightly build (65.0a1) and in 64.0b15, which seems to match comment 3.
|
||
Updated•5 years ago
|
|
||
Comment 6•5 years ago
|
||
This crash might be a regression from prefersReducedMotion bug 1505897.
|
|
||
Comment 7•5 years ago
|
||
Re-ran the regression range and this makes a lot more sense. 37:41.33 INFO: Last good revision: b03a3a18a4078fbc0e4656b78ce888b389645982 37:41.33 INFO: First bad revision: 759d828c5c2d519540fd484b745b6cf70e0ab91a 37:41.33 INFO: Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b03a3a18a4078fbc0e4656b78ce888b389645982&tochange=759d828c5c2d519540fd484b745b6cf70e0ab91a
|
|
||
Comment 8•5 years ago
|
||
Any fix for this short of disabling the feature for Android 4.1 devices?
Flags: needinfo?(hikezoe)
|
Assignee | |
Comment 9•5 years ago
|
||
It seems Settings.Global which is used for the feature was introduced on Android 4.2. And bug 1510611 fixed this crash? If not, we need to bail out from prefersReducedMotion() on Android 4.1 devices. Anyway, taking now. I think I have an Android 4.1 device somewhere, so I can check it.
Assignee: nobody → hikezoe
Status: NEW → ASSIGNED
Flags: needinfo?(hikezoe)
|
|
||
Comment 10•5 years ago
|
||
I don't know if bug 1510611 fixes the issue. I can check tomorrow's build when it is included as part of the next Nightly.
|
|
Assignee | |
Comment 11•5 years ago
|
||
Confirmed on an Android 4.1.2 device that bug 1510611 didn't fix the crash, we need to bail out there.
|
|
Assignee | |
Comment 12•5 years ago
|
||
Settings.Global can't be used on such devices.
|
||
Comment 13•5 years ago
|
||
Pushed by hikezoe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1414f3021baf Bail out from prefersReducedMotion() if the target device is Android 4.1 or older. r=snorp
|
|
Assignee | |
Comment 14•5 years ago
|
||
Comment on attachment 9030608 [details] Bug 1512037 - Bail out from prefersReducedMotion() if the target device is Android 4.1 or older. r?snorp! [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: Bug 1478505 User impact if declined: Crash Is this code covered by automated tests?: Yes Has the fix been verified in Nightly?: No Needs manual test from QE?: Yes If yes, steps to reproduce: Open https://www.bbc.com/news on Android 4.1 devices List of other uplifts needed: None Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): The change here is actually just bailing out from a function which uses a Class can't be used on old Android devices. String changes made/needed:
Attachment #9030608 -
Flags: approval-mozilla-release?
Attachment #9030608 -
Flags: approval-mozilla-beta?
|
|
Assignee | |
Comment 15•5 years ago
|
||
I couldn't add additional comments for the question about automated tests in the uplift request editor. (In reply to Hiroyuki Ikezoe (:hiro) from comment #14) > Is this code covered by automated tests?: Yes To be precise, we have automated tests but we don't run them on Android 4.1 or older devices on our CIs unfortunately.
|
|
||
Comment 16•5 years ago
|
||
If this crash affects 64, we should also uplift the fix to GECKOVIEW_64_RELBRANCH.
|
|
||
Comment 17•5 years ago
|
||
Comment on attachment 9030608 [details] Bug 1512037 - Bail out from prefersReducedMotion() if the target device is Android 4.1 or older. r?snorp! [GeckoView Uplift Approval Request] If this is not a sec:{high,crit} bug, please state case for consideration: User impact if declined: Fix Landed on Version: Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): String or UUID changes made by this patch:
Attachment #9030608 -
Flags: approval-mozilla-geckoview64?
|
||
Comment 18•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1414f3021baf
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
|
||
Comment 19•5 years ago
|
||
Comment on attachment 9030608 [details] Bug 1512037 - Bail out from prefersReducedMotion() if the target device is Android 4.1 or older. r?snorp! fix a crash on older android, approved for 65.0b5 and 64.0.1 AFAIK we'll merge from release to gv64 so clearing that flag.
Attachment #9030608 -
Flags: approval-mozilla-release?
Attachment #9030608 -
Flags: approval-mozilla-release+
Attachment #9030608 -
Flags: approval-mozilla-geckoview64?
Attachment #9030608 -
Flags: approval-mozilla-beta?
Attachment #9030608 -
Flags: approval-mozilla-beta+
|
|
||
Comment 20•5 years ago
|
||
BTW should the @RequiresApi annotation from bug 1510611 be removed for this function now that it includes this guard?
Flags: needinfo?(hikezoe)
|
|
Assignee | |
Comment 21•5 years ago
|
||
No, I don't think so. It seems to be just for lint tools.
Flags: needinfo?(hikezoe)
|
||
Comment 22•5 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-beta/rev/ac3f8e63166b
|
|
||
Comment 23•5 years ago
|
||
Backout incoming, https://hg.mozilla.org/mozilla-central/rev/985b82d30afa is not part of beta.
|
||
Comment 24•5 years ago
|
||
Backed out changeset ac3f8e63166b (Bug 1512037) for causing Android build bustages Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&resultStatus=testfailed%2Cbusted%2Cexception&selectedJob=216640651&revision=a13db67049a28292318e12077d448f8a1a70b2a1 Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=216640651&repo=mozilla-beta&lineNumber=3677 Backout: https://hg.mozilla.org/releases/mozilla-beta/rev/b0e263db0edfe55fb69c5dd6015f73d6b52a2d23
Flags: needinfo?(hikezoe)
|
|
||
Comment 25•5 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-beta/rev/022e5d97749f
|
|
||
Updated•5 years ago
|
Flags: needinfo?(hikezoe)
|
|
||
Updated•5 years ago
|
Whiteboard: [geckoview] → [geckoview:p1]
|
|
||
Comment 26•5 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-release/rev/d3581c5a674e
|
||
Updated•5 years ago
|
|
||
Comment 27•5 years ago
|
||
Unfortunately, we don't have devices with Android 4.1 and we performed a smoke on Lenovo A536(Android 4.4.2) and visit also bc.com/news with no success in reproducing the crash.
|
|
||
Comment 28•5 years ago
|
||
Tested on 65.0b5 with Lenovo A536 (Android 4.4.2) and Prestigio Grace X5 (Android 4.4.2) and the app didn't crash when we visit bbc.com/news and opened/closed articles.
|
|
||
Comment 29•5 years ago
|
||
Marking the bug VERIFIED based on comment 27 and comment 28 and on the fact that we didn't find any crash on 64.0.2 with Lenovo A536 (Android 4.4.2).
Status: RESOLVED → VERIFIED
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•