151219 - Pressing Enter should trigger the submit button of the current form, not the first submit button that's found

Status: VERIFIED DUPLICATE of bug 28763

(Core :: DOM: Core & HTML, defect)

Description

[:deanis74]

Searched but couldn't find a dupe for this.

1. Go to http://bugzilla.mozilla.org/query.cgi
2. In the first email field enter "[e-mail]"
3. Press Enter

Expected Results: Search Executes

Actual Results: A "boolean chart" is added to the form because that's the first
submit button that's found.  This seems counter-intuitive to me.  If I'm
entering data in a form and want to submit it, pressing Enter should submit the
form I'm working in, regardless of whether there's a subform or not.

Comment 1

[Vladimir Ermakov]

*** This bug has been marked as a duplicate of 28763 ***

Comment 2

[:deanis74]

No, this isn't a duplicate.  That bug is for a specific bugzilla issue, this is
a general form submission bug.  The bugzilla query page just provides a nice
example.

Comment 3

[John Keiser (jkeiser)]

Someone want to suggest a good alternative to picking the first submit button? 
I don't really think we're going to change this, because IE does it this way too
and we're specifically mimicking their behavior.  Any button we pick is going to
break somebody, so we may as well pick the same button IE does.

Comment 4

[:deanis74]

I kind of liked my idea.  Pick the submit button for the form that corresponds
to the field that has focus.

Comment 5

[Boris Zbarsky [:bzbarsky]]

What is a "subform"?  Exactly what feat of mind-reading are we supposed to
perform to determine which submit button you would want used?

I feel that IE compat is the only way to go here, since there are no convincing
arguments for picking a different submit element.. if there are, please present
them.

Comment 6

[Boris Zbarsky [:bzbarsky]]

> Pick the submit button for the form that corresponds to the field that has focus.

What does that mean?  In HTML there is no correspondence between fields and
submit buttons.  There is a one-to-many relationship between forms and fields
and a one-to-many relationship between forms and submit buttons.  That is all.

Comment 7

[:deanis74]

Huh.  Can we just forget everything I said?  I could have sworn that I looked
the other day and the query page contained a form embedded within a form, and
that the Add buttons corresponded to the embedded form.  Now I see it's all one
form, and all we can do is pick the first submit.  I guess this is bug 28763
after all.

*** This bug has been marked as a duplicate of 28763 ***

Comment 8

[Boris Zbarsky [:bzbarsky]]

> a form embedded within a form

That's actually explicitly disallowed by the HTML DTD and our parser enforces
that... ;)

Verified that the whole mess sucks.

Comment 9

[:deanis74]

> That's actually explicitly disallowed by the HTML DTD

Jeez, yeah.  What the heck was I on??