Closed Bug 1512459 Opened 2 years ago Closed 2 years ago

Remove webrtc sndio audio device

Categories

(Core :: WebRTC: Audio/Video, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: dminor, Assigned: dminor)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

As far as I know, the sndio webrtc audio device code is now unused and we are doing "full duplex" using the cubeb library.

It would be nice to be able to remove the sndio device as we are trying to minimize local changes we have against upstream webrtc.org to make future updates less painful.
Jan, do you know if this code is still in use anywhere? Thanks!
Flags: needinfo?(jbeich)
From talking to padenot it sounds like substantial local modifications to Firefox would be required for this code to still to be used, so it doesn't make sense to retain this in tree.
This code is unused and can be removed.
(In reply to Dan Minor [:dminor] from comment #1)
> Jan, do you know if this code is still in use anywhere? Thanks!

Landry is the person to ask. Only OpenBSD uses sndio by default. Otherwise, WebRTC uses libcubeb after bug 1397793 after which bug 1393119 disconnected audio_device from the build.
Flags: needinfo?(jbeich) → needinfo?(landry)
I think https://bugzilla.mozilla.org/show_bug.cgi?id=1221580 implemented the full-duplex backend for cubeb, and this webrtc code is indeed not used/deprecated. Right now, recording doesnt work with sndiod & cubeb (and since some releases, so im not sure related to the last webrtc update) but that's i think another issue. Alex, fine with this removal ?
Flags: needinfo?(landry) → needinfo?(alex)
Rank: 19
Priority: -- → P2
I agree, webrtc audio drivers are not needed any longer, cubeb handles
both playback and recording.
Flags: needinfo?(alex)
Assignee: nobody → dminor
Status: NEW → ASSIGNED
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa0a179388e9
Remove webrtc sndio audio device; r=padenot
Oh and for the record, if cubeb recording was broken at some point (last i tried was some weeks ago on beta), it seems it's not the case anymore. On 64.0rc3 i can use https://www.webrtc-experiment.com/RecordRTC/ to record and successfully playback the result. So this code is not used, and the cubeb sndiod full-duplex support works as of 64.0.
(In reply to Landry Breuil (:gaston) from comment #8)
> Oh and for the record, if cubeb recording was broken at some point (last i
> tried was some weeks ago on beta), it seems it's not the case anymore. On
> 64.0rc3 i can use https://www.webrtc-experiment.com/RecordRTC/ to record and
> successfully playback the result. So this code is not used, and the cubeb
> sndiod full-duplex support works as of 64.0.

Thank you for double checking! I was going to ask you to file a bug if that was not the case.
https://hg.mozilla.org/mozilla-central/rev/fa0a179388e9
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
No longer depends on: 1646904
You need to log in before you can comment on or make changes to this bug.