1512459 - Remove webrtc sndio audio device

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P2)

Description

[Dan Minor [:dminor]]

As far as I know, the sndio webrtc audio device code is now unused and we are doing "full duplex" using the cubeb library.

It would be nice to be able to remove the sndio device as we are trying to minimize local changes we have against upstream webrtc.org to make future updates less painful.

Comment 1

[Dan Minor [:dminor]]

Jan, do you know if this code is still in use anywhere? Thanks!

Comment 2

[Dan Minor [:dminor]]

From talking to padenot it sounds like substantial local modifications to Firefox would be required for this code to still to be used, so it doesn't make sense to retain this in tree.

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 1512459 - Remove webrtc sndio audio device; r=padenot

This code is unused and can be removed.

Comment 4

[Jan Beich]

(In reply to Dan Minor [:dminor] from comment #1)
> Jan, do you know if this code is still in use anywhere? Thanks!

Landry is the person to ask. Only OpenBSD uses sndio by default. Otherwise, WebRTC uses libcubeb after bug 1397793 after which bug 1393119 disconnected audio_device from the build.

Comment 5

[Landry Breuil (:gaston)]

I think https://bugzilla.mozilla.org/show_bug.cgi?id=1221580 implemented the full-duplex backend for cubeb, and this webrtc code is indeed not used/deprecated. Right now, recording doesnt work with sndiod & cubeb (and since some releases, so im not sure related to the last webrtc update) but that's i think another issue. Alex, fine with this removal ?

Comment 6

[Alexandre Ratchov]

I agree, webrtc audio drivers are not needed any longer, cubeb handles
both playback and recording.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa0a179388e9
Remove webrtc sndio audio device; r=padenot

Comment 8

[Landry Breuil (:gaston)]

Oh and for the record, if cubeb recording was broken at some point (last i tried was some weeks ago on beta), it seems it's not the case anymore. On 64.0rc3 i can use https://www.webrtc-experiment.com/RecordRTC/ to record and successfully playback the result. So this code is not used, and the cubeb sndiod full-duplex support works as of 64.0.

Comment 9

[Dan Minor [:dminor]]

(In reply to Landry Breuil (:gaston) from comment #8)
> Oh and for the record, if cubeb recording was broken at some point (last i
> tried was some weeks ago on beta), it seems it's not the case anymore. On
> 64.0rc3 i can use https://www.webrtc-experiment.com/RecordRTC/ to record and
> successfully playback the result. So this code is not used, and the cubeb
> sndiod full-duplex support works as of 64.0.

Thank you for double checking! I was going to ask you to file a bug if that was not the case.

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/fa0a179388e9