1512645 - Customize mode buttons have wrong text color on :hover:active

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Tim Nguyen :ntim]

Attachment: Screen Shot 2018-12-07 at 09.56.08.png

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1512645 - Fix customization button colors. r=ntim

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a3a8b70b8ba
Fix customization button colors. r=ntim

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/0a3a8b70b8ba

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 9034674 [details]
Bug 1512645 - Fix customization button colors. r=ntim

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: bug 1473922

User impact if declined: minor visual glitch

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: Enter customize mode in Nightly on Mac and click the buttons at the very bottom (Toolbars, Themes, Density).

List of other uplifts needed: -

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): trivial fix

String changes made/needed: -

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9034674 [details]
Bug 1512645 - Fix customization button colors. r=ntim

[Triage Comment]
Simple CSS fix for a minor UI glitch. Approved for 65.0b10.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/efa8fa7ce739

Comment 7

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 66.0a1 (BuildId:20190108215840) and Firefox 65.0b10 (provided in comment 6) on macOS 10.12.6