Customize mode buttons have wrong text color on :hover:active

VERIFIED FIXED in Firefox 65

Status

()

defect
P1
normal
VERIFIED FIXED
5 months ago
4 months ago

People

(Reporter: ntim, Assigned: dao)

Tracking

({regression})

unspecified
Firefox 66
Unspecified
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox64 unaffected, firefox65 verified, firefox66 verified)

Details

Attachments

(2 attachments)

Reporter

Description

5 months ago
No description provided.
Assignee

Updated

5 months ago
Priority: -- → P1
Assignee: nobody → dao+bmo

Comment 2

4 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a3a8b70b8ba
Fix customization button colors. r=ntim

Comment 3

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0a3a8b70b8ba
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Assignee

Updated

4 months ago
Flags: qe-verify+
OS: Unspecified → Mac OS X
Assignee

Comment 4

4 months ago

Comment on attachment 9034674 [details]
Bug 1512645 - Fix customization button colors. r=ntim

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: bug 1473922

User impact if declined: minor visual glitch

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: Enter customize mode in Nightly on Mac and click the buttons at the very bottom (Toolbars, Themes, Density).

List of other uplifts needed: -

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): trivial fix

String changes made/needed: -

Attachment #9034674 - Flags: approval-mozilla-beta?

Comment on attachment 9034674 [details]
Bug 1512645 - Fix customization button colors. r=ntim

[Triage Comment]
Simple CSS fix for a minor UI glitch. Approved for 65.0b10.

Attachment #9034674 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

This issue is verified fixed using Firefox 66.0a1 (BuildId:20190108215840) and Firefox 65.0b10 (provided in comment 6) on macOS 10.12.6

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.