1473922 - Load button.css as a document stylesheet

Status: RESOLVED FIXED

(Toolkit :: Themes, enhancement, P3)

Description

[:Paolo Amadini]

This is part of the work tracked in bug 1470830.

Comment 1

[:Paolo Amadini]

Attachment: Bug 1473922 - Load "button.css" as a document stylesheet.

Review commit: https://reviewboard.mozilla.org/r/255376/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255376/

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8990337 [details]
Bug 1473922 - Load "button.css" as a document stylesheet.

https://reviewboard.mozilla.org/r/255376/#review262228

Comment 3

[:Paolo Amadini]

Comment on attachment 8990337 [details]
Bug 1473922 - Load "button.css" as a document stylesheet.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/255376/diff/1-2/

Comment 4

[Tim Nguyen :ntim]

I won't be taking this, but here's what my initial look into this gave:
- There are some margins that use !important in button.css, !important should probably be removed in those cases
- the :hover/:active/[default] text color seem to override the colors that common.inc.css set on buttons, this could be solved by !important sprinkling on common.inc.css + stylesheets overriding common.inc.css' button text color.
- There's a similar :active text color issue on the permission prompt buttons
- There's also another similar :active text color issue on the @hudButton@ styles.

Comment 5

[Tim Nguyen :ntim]

Attachment: WIP - button.css doc stylesheet

Comment 6

[Tim Nguyen :ntim]

uhh, bzexport no, I don’t want to assign myself.

Comment 7

[Dão Gottwald [:dao]]

Looking into what's needed to drive this home.

Comment 8

[Dão Gottwald [:dao]]

https://screenshots.mattn.ca/compare/?oldProject=try&oldRev=1bb0b4bc5f8e8dfce23577f01b7eec21b150920d&newProject=try&newRev=3b6510dfa6161c4c96285f1d2cfceb05e6a3e3a0

https://screenshots.mattn.ca/compare/?oldProject=try&oldRev=a74ad69dd2e3dd6a6719fcd057513d8293775053&newProject=try&newRev=658480cadb16acb9a4d94582188f84ffe9de66ea

One minor problem on with disabled and default in-content buttons on Linux and Mac that should be easy to fix:

https://screenshots.mattn.ca/comparisons/try/a74ad69dd2e3dd6a6719fcd057513d8293775053/try/658480cadb16acb9a4d94582188f84ffe9de66ea/linux64/preferences_02_prefsGeneral-browsingGroup.png

https://screenshots.mattn.ca/comparisons/try/a74ad69dd2e3dd6a6719fcd057513d8293775053/try/658480cadb16acb9a4d94582188f84ffe9de66ea/osx-10-10/preferences_02_prefsGeneral-browsingGroup.png

https://screenshots.mattn.ca/comparisons/try/a74ad69dd2e3dd6a6719fcd057513d8293775053/try/658480cadb16acb9a4d94582188f84ffe9de66ea/osx-10-10/preferences_03_prefsGeneral-connectionDialog.png

ntim, want to finish this or should I?

Comment 9

[Tim Nguyen :ntim]

(In reply to Dão Gottwald [::dao] from comment #8)
> ntim, want to finish this or should I?

Please feel free to finish this.

Comment 10

[Dão Gottwald [:dao]]

Attachment: Bug 1473922 - Load button.css as a document stylesheet. r?bgrins

Comment 11

[Dão Gottwald [:dao]]

Attachment: Bug 1473922 - Load button.css as a document stylesheet. r?bgrins

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f67ea0716dd
Load button.css as a document stylesheet. r=bgrins

Comment 13

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/1f67ea0716dd