Closed Bug 1473922 Opened 3 years ago Closed 2 years ago

Load button.css as a document stylesheet

Categories

(Toolkit :: Themes, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox63 --- wontfix
firefox64 --- wontfix
firefox65 --- fixed

People

(Reporter: Paolo, Assigned: dao)

References

Details

Attachments

(2 files, 2 obsolete files)

This is part of the work tracked in bug 1470830.
Comment on attachment 8990337 [details]
Bug 1473922 - Load "button.css" as a document stylesheet.

https://reviewboard.mozilla.org/r/255376/#review262228
Attachment #8990337 - Flags: review?(bgrinstead) → review+
I won't be taking this, but here's what my initial look into this gave:
- There are some margins that use !important in button.css, !important should probably be removed in those cases
- the :hover/:active/[default] text color seem to override the colors that common.inc.css set on buttons, this could be solved by !important sprinkling on common.inc.css + stylesheets overriding common.inc.css' button text color.
- There's a similar :active text color issue on the permission prompt buttons
- There's also another similar :active text color issue on the @hudButton@ styles.
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
uhh, bzexport no, I don’t want to assign myself.
Assignee: ntim.bugs → nobody
Status: ASSIGNED → NEW
Attachment #8990337 - Attachment is obsolete: true
Looking into what's needed to drive this home.
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Summary: Load "button.css" as a document stylesheet → Load button.css as a document stylesheet
Depends on: 1502731
(In reply to Dão Gottwald [::dao] from comment #8)
> ntim, want to finish this or should I?

Please feel free to finish this.
Flags: needinfo?(ntim.bugs)
Attachment #9023937 - Attachment is obsolete: true
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1f67ea0716dd
Load button.css as a document stylesheet. r=bgrins
Depends on: 1506212
Depends on: 1506214
https://hg.mozilla.org/mozilla-central/rev/1f67ea0716dd
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Depends on: 1506342
Depends on: 1506815
Depends on: 1506858
Depends on: 1506810
Depends on: 1507109
Depends on: 1509629
Depends on: 1509630
Depends on: 1509633
Depends on: 1509631
Depends on: 1510565
Depends on: 1511208
Depends on: 1511652
Depends on: 1512312
Depends on: 1512645
Depends on: 1510353
Depends on: 1514058
Depends on: 1514277
Depends on: 1516634
Depends on: 1516770
Depends on: 1517468
You need to log in before you can comment on or make changes to this bug.