Load button.css as a document stylesheet

RESOLVED FIXED in Firefox 65

Status

()

P3
normal
RESOLVED FIXED
9 months ago
3 months ago

People

(Reporter: Paolo, Assigned: dao)

Tracking

Trunk
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 wontfix, firefox64 wontfix, firefox65 fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

9 months ago
This is part of the work tracked in bug 1470830.
Comment hidden (mozreview-request)
Comment on attachment 8990337 [details]
Bug 1473922 - Load "button.css" as a document stylesheet.

https://reviewboard.mozilla.org/r/255376/#review262228
Attachment #8990337 - Flags: review?(bgrinstead) → review+
Comment hidden (mozreview-request)

Comment 4

6 months ago
I won't be taking this, but here's what my initial look into this gave:
- There are some margins that use !important in button.css, !important should probably be removed in those cases
- the :hover/:active/[default] text color seem to override the colors that common.inc.css set on buttons, this could be solved by !important sprinkling on common.inc.css + stylesheets overriding common.inc.css' button text color.
- There's a similar :active text color issue on the permission prompt buttons
- There's also another similar :active text color issue on the @hudButton@ styles.

Updated

6 months ago
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED

Comment 6

6 months ago
uhh, bzexport no, I don’t want to assign myself.
Assignee: ntim.bugs → nobody
Status: ASSIGNED → NEW
(Assignee)

Updated

6 months ago
Attachment #8990337 - Attachment is obsolete: true
(Assignee)

Comment 7

5 months ago
Looking into what's needed to drive this home.
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Summary: Load "button.css" as a document stylesheet → Load button.css as a document stylesheet

Updated

5 months ago
Depends on: 1502731

Comment 9

4 months ago
(In reply to Dão Gottwald [::dao] from comment #8)
> ntim, want to finish this or should I?

Please feel free to finish this.
Flags: needinfo?(ntim.bugs)
Attachment #9023937 - Attachment is obsolete: true

Comment 12

4 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1f67ea0716dd
Load button.css as a document stylesheet. r=bgrins

Updated

4 months ago
Depends on: 1506212

Updated

4 months ago
Depends on: 1506214

Comment 13

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1f67ea0716dd
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
(Assignee)

Updated

4 months ago
Depends on: 1506342
status-firefox63: affected → wontfix
status-firefox64: --- → wontfix
(Assignee)

Updated

4 months ago
Depends on: 1506815
(Assignee)

Updated

4 months ago
Depends on: 1506858
(Assignee)

Updated

4 months ago
Depends on: 1506810
(Assignee)

Updated

4 months ago
Depends on: 1507109

Updated

4 months ago
Depends on: 1509629

Updated

4 months ago
Depends on: 1509630

Updated

4 months ago
Depends on: 1509633

Updated

4 months ago
Depends on: 1509631

Updated

4 months ago
Depends on: 1510565
(Assignee)

Updated

4 months ago
Depends on: 1511208
(Assignee)

Updated

4 months ago
Depends on: 1511652

Updated

3 months ago
Depends on: 1512312

Updated

3 months ago
Depends on: 1512645
(Assignee)

Updated

3 months ago
Depends on: 1510353

Updated

3 months ago
Depends on: 1514058

Updated

3 months ago
Depends on: 1514277

Updated

3 months ago
Depends on: 1516634

Updated

3 months ago
Depends on: 1516770

Updated

3 months ago
Depends on: 1517468
You need to log in before you can comment on or make changes to this bug.