1512730 - Update webrender to 41c12cabc42228dda6a2d2628c9b24df9aca66b4 (WR PR #3398)

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1512624 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/wrupdater/blob/master/try-latest-webrender.sh

Comment 1

[u587307]

WR @ commit 41c12cabc42228dda6a2d2628c9b24df9aca66b4 - servo/webrender#3398 - on HG rev 13f891b92db1:    https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6596c365d20de558ae0d62b39cd17ba5bb2145c

Comment 2

[u587307]

Attachment: Bug 1512730 - Update webrender to commit 41c12cabc42228dda6a2d2628c9b24df9aca66b4 (WR PR #3398). r?kats

https://github.com/servo/webrender/pull/3398

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d24ac329431
Update webrender to commit 41c12cabc42228dda6a2d2628c9b24df9aca66b4 (WR PR #3398). r=kats

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5d24ac329431

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 9030363 [details]
Bug 1512730 - Update webrender to commit 41c12cabc42228dda6a2d2628c9b24df9aca66b4 (WR PR #3398). r?kats

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined: For users selected to use WebRender (Windows + certain NVIDIA hardware), they will have their GPU crash periodically while browsing. This will downgrade them to basic compositing resulting in worse performance and denies us telemetry results for WebRender for the duration of the session.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): It is not risky because the change is small, well understood, and limited as an internal detail to WebRender.

String changes made/needed:

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9030363 [details]
Bug 1512730 - Update webrender to commit 41c12cabc42228dda6a2d2628c9b24df9aca66b4 (WR PR #3398). r?kats

[Triage Comment]
Fixes GPU crashes for users running with WebRender enabled. Approved for 65.0b5.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/86e560ca1e29