Closed
Bug 1512737
Opened 5 years ago
Closed 5 years ago
Missing tests for HRTF
Categories
(Core :: Web Audio, defect, P3)
Core
Web Audio
Tracking
()
RESOLVED
FIXED
mozilla66
People
(Reporter: decoder, Assigned: karlt)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(1 file)
We cross-checked 0% coverage files from CI/Tests with fuzzing results and found that we cover several parts of WebAudio/HRTF in fuzzing that apparently don't have tests: 62.5% dom/media/webaudio/blink/HRTFKernel.h 29.03% dom/media/webaudio/blink/HRTFDatabase.cpp 40.26% dom/media/webaudio/blink/HRTFElevation.cpp 33.33% dom/media/webaudio/blink/HRTFDatabase.h 80.0% dom/media/webaudio/blink/HRTFDatabaseLoader.h 4.0% dom/media/webaudio/blink/HRTFPanner.cpp 97.37% dom/media/webaudio/FFTBlock.cpp 88.0% dom/media/webaudio/blink/HRTFKernel.cpp 42.86% dom/media/webaudio/blink/HRTFElevation.h It might be worth investigating if our tests are supposed to cover these parts and just broken, or if they are missing.
Reporter | ||
Updated•5 years ago
|
Blocks: untestedcode-codecoverage
Assignee | ||
Comment 1•5 years ago
|
||
Thank you for detecting and reporting this. https://hg.mozilla.org/mozilla-central/rev/5636007e3d1a110bbce81f46b61cee5602249cc1#l4.12 attempted to keep these tested but added a "type" property instead of setting the "panningModel" attribute.
Assignee | ||
Comment 2•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=259173af3946e62cccd6b86ba9265985cae5270a
Assignee | ||
Comment 3•5 years ago
|
||
Updated•5 years ago
|
status-firefox64:
--- → wontfix
status-firefox66:
--- → fix-optional
status-firefox-esr60:
--- → wontfix
Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b26564e76c51 assign HRTF to panningModel attribute instead of adding type property r=padenot
Comment 5•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Comment 6•5 years ago
|
||
bugherder uplift |
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•