1512737 - Missing tests for HRTF

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P3)

Description

[Christian Holler (:decoder)]

We cross-checked 0% coverage files from CI/Tests with fuzzing results and found that we cover several parts of WebAudio/HRTF in fuzzing that apparently don't have tests:

62.5%    dom/media/webaudio/blink/HRTFKernel.h
29.03%   dom/media/webaudio/blink/HRTFDatabase.cpp
40.26%   dom/media/webaudio/blink/HRTFElevation.cpp
33.33%   dom/media/webaudio/blink/HRTFDatabase.h
80.0%    dom/media/webaudio/blink/HRTFDatabaseLoader.h
4.0%     dom/media/webaudio/blink/HRTFPanner.cpp
97.37%   dom/media/webaudio/FFTBlock.cpp
88.0%    dom/media/webaudio/blink/HRTFKernel.cpp
42.86%   dom/media/webaudio/blink/HRTFElevation.h


It might be worth investigating if our tests are supposed to cover these parts and just broken, or if they are missing.

Comment 1

[Karl Tomlinson (:karlt)]

Thank you for detecting and reporting this.

https://hg.mozilla.org/mozilla-central/rev/5636007e3d1a110bbce81f46b61cee5602249cc1#l4.12 attempted to keep these tested but added a "type" property instead of setting the "panningModel" attribute.

Comment 2

[Karl Tomlinson (:karlt)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=259173af3946e62cccd6b86ba9265985cae5270a

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: Bug 1512737 assign HRTF to panningModel attribute instead of adding type property r?padenot

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b26564e76c51
assign HRTF to panningModel attribute instead of adding type property r=padenot

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/b26564e76c51

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/39fe709c6cf8