Closed Bug 1512788 Opened 9 months ago Closed 9 months ago

Address Book API events stop working after first extension shutdown

Categories

(Thunderbird :: Add-Ons: Extensions API, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 65.0

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

Attachments

(1 file)

I messed up and removed the listeners/observers for ALL address book extensions after ONE of them is shutdown.
Attachment #9030066 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9030066 [details] [diff] [review]
1512788-addrbook-listeners-1.diff

Review of attachment 9030066 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #9030066 - Flags: review?(mkmelin+mozilla) → review+
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/463d4f409e9a
Keep address book listeners listening unless there are no extensions using them; r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED

Actually this makes things worse; if you don't have your listeners installed, your cache will never be invalidated.

Hmm, I think you are right. :(

Target Milestone: --- → Thunderbird 65.0
Depends on: 1521958
You need to log in before you can comment on or make changes to this bug.