Closed
Bug 1512788
Opened 5 years ago
Closed 5 years ago
Address Book API events stop working after first extension shutdown
Categories
(Thunderbird :: Add-Ons: Extensions API, defect)
Thunderbird
Add-Ons: Extensions API
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 65.0
People
(Reporter: darktrojan, Assigned: darktrojan)
References
Details
Attachments
(1 file)
|
9.49 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
I messed up and removed the listeners/observers for ALL address book extensions after ONE of them is shutdown.
|
Assignee | |
Comment 1•5 years ago
|
||
Attachment #9030066 -
Flags: review?(mkmelin+mozilla)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9030066 [details] [diff] [review] 1512788-addrbook-listeners-1.diff Review of attachment 9030066 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, r=mkmelin
Attachment #9030066 -
Flags: review?(mkmelin+mozilla) → review+
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/463d4f409e9a Keep address book listeners listening unless there are no extensions using them; r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
|
||
Comment 4•5 years ago
|
||
Actually this makes things worse; if you don't have your listeners installed, your cache will never be invalidated.
|
|
Assignee | |
Comment 5•5 years ago
|
||
Hmm, I think you are right. :(
|
|
Assignee | |
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 65.0
You need to log in
before you can comment on or make changes to this bug.
Description
•