1512884 - remove broadcasters from mailnews/

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1489447 +++

Remove broadcasters from mailnews.

Turns out to be pretty trivial. 
broadcaster_attachSignature was not used for anything

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1512884_mailnews_broadcaster.patch

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: bug1512884_mailnews_broadcaster.patch

Forgot a final qrefresh.

Comment 3

[:aceman]

Comment on attachment 9030169 [details] [diff] [review]
bug1512884_mailnews_broadcaster.patch

Review of attachment 9030169 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/prefs/content/am-copies.js
@@ +292,5 @@
>  // Check the Fcc Self item and setup associated picker state
>  function setupFccItems()
>  {
> +  let checked = document.getElementById("identity.doFcc").checked;
> +  document.querySelectorAll(".depends-on-do-fcc").forEach(e => {

Another clever way to open-code observers? :)

Comment 4

[Magnus Melin [:mkmelin]]

Yeah, I think it's actually much clearer than using observers.

Comment 5

[Jorg K (CEST = GMT+2)]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0a963a4631f255f0aade032bf7239e19f8fc1539

Comment 6

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/comm-central/rev/38dbf750eea272967b0d6333e0f156499cb94bdc

Comment 7

[[e-mail]]

I overlooked this change between Thunderbird 60 and Thunderbird 68. Should it be added to the list of removed XUL elements?

Comment 8

[Magnus Melin [:mkmelin]]

<broadcaster> still exists (only on the kill-list). Of course if an add-on was relying on an existing broadcaster, then it needs to adapt.