remove broadcasters from mailnews/

RESOLVED FIXED in Thunderbird 66.0

Status

enhancement
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: mkmelin, Assigned: mkmelin)

Tracking

(Blocks 1 bug, {meta})

Trunk
Thunderbird 66.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

6 months ago
+++ This bug was initially created as a clone of Bug #1489447 +++

Remove broadcasters from mailnews.

Turns out to be pretty trivial. 
broadcaster_attachSignature was not used for anything
Assignee

Comment 1

6 months ago
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #9030168 - Flags: review?(acelists)
Assignee

Comment 2

6 months ago
Forgot a final qrefresh.
Attachment #9030168 - Attachment is obsolete: true
Attachment #9030168 - Flags: review?(acelists)
Attachment #9030169 - Flags: review?(acelists)

Comment 3

5 months ago
Comment on attachment 9030169 [details] [diff] [review]
bug1512884_mailnews_broadcaster.patch

Review of attachment 9030169 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/prefs/content/am-copies.js
@@ +292,5 @@
>  // Check the Fcc Self item and setup associated picker state
>  function setupFccItems()
>  {
> +  let checked = document.getElementById("identity.doFcc").checked;
> +  document.querySelectorAll(".depends-on-do-fcc").forEach(e => {

Another clever way to open-code observers? :)
Attachment #9030169 - Flags: review?(acelists) → review+
Assignee

Comment 4

5 months ago
Yeah, I think it's actually much clearer than using observers.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/38dbf750eea272967b0d6333e0f156499cb94bdc
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 66.0
You need to log in before you can comment on or make changes to this bug.