1513349 - Editing a tree cell causes other cells in the row to become invisible

Status: VERIFIED FIXED

(Toolkit :: Themes, defect)

Description

[Alice0775 White]

Attachment: screenshot

[Tracking Requested - why for this release]: UI becomes broken

See attached screenshot

Steps To Reproduce:
1. Remember password
2. Open about:preferences#privacy
3. Click on [Saved Login] button
4. Click on [Show Password] Button
5. Double click on a user name or a password field to edit it

Actual Results:
Site name and other column becomes invisible.

Expected Results:
Should be visible(readable)


Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f643580be3cb0f73a5f175fa366730ab16f6a42b&tochange=9a4db52c22c20c1d872c1eaac1bafd4b6b1cca66

Regressed by: 9a4db52c22c2	Tim Nguyen — Bug 1508142 - Remove remains of tree cell-based selection code. r=bzbarsky,bgrins

Comment 1

[Alice0775 White]

:ntim
Your patch seems to cause the regression, can you please look into this?

Comment 2

[Tim Nguyen :ntim]

This change [0] regressed this.

Reintroducing support for currentColumn + the active selector would be overkill IMO.

I believe these two rules can just be removed altogether, since the .tree-input overlays the edited cell anyway (hiding the text underneath).

[0]: https://hg.mozilla.org/integration/autoland/rev/9a4db52c22c2#l23.12

Comment 4

[Tim Nguyen :ntim]

Attachment: Bug 1513349 - Remove now erronous tree cell editing styles. r=dao

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af677b06f934
Remove now erroneous tree cell editing styles. r=dao

Comment 6

[Tim Nguyen :ntim]

Comment on attachment 9030553 [details]
Bug 1513349 - Remove now erronous tree cell editing styles. r=dao

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1508142

User impact if declined: See comment 0 and bug 1513329 comment 0

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: See comment 0 and bug 1513329 comment 0

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): small CSS removal

String changes made/needed: no

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/af677b06f934

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9030553 [details]
Bug 1513349 - Remove now erronous tree cell editing styles. r=dao

[Triage Comment]
Removes some unnecessary and erroneous tree cell editing rules. Approved for 65.0b5.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/eed9d1166b69

Comment 10

[Gabi Cheta [:Gabi] Desktop QA]

Reproduced the issue on 65.0b4.
Verified as fixed with 65.0b5 build from taskcluster and Nightly 66.0a1 on Windows 10x64, macOS 10.14 and Ubuntu 14.04.