Closed
Bug 1508142
Opened 6 years ago
Closed 6 years ago
Remove platform code related to tree[seltype="cell|text"]
Categories
(Core :: XUL, task)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: ntim, Assigned: ntim)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
I looked again at bug 1430374 and I realized that there is some code that I forgot to remove, see:
https://searchfox.org/mozilla-central/diff/e5158d88eff369883b9fa994276d0b06cfe7ca8f/toolkit/content/widgets/tree.xml#240
That diff contains everything that needs to be reversed.
|
Assignee | |
Comment 1•6 years ago
|
||
(In reply to Tim Nguyen :ntim (please use needinfo?) from comment #0)
> I looked again at bug 1430374
I meant bug 1471542
|
|
Assignee | |
Comment 2•6 years ago
|
||
This is the full commit: https://github.com/mozilla/gecko-dev/commit/e5158d88eff369883b9fa994276d0b06cfe7ca8f
|
|
Assignee | |
Updated•6 years ago
|
Component: XUL Widgets → XUL
Product: Toolkit → Core
|
|
Assignee | |
Comment 3•6 years ago
|
||
Depends on D12224
|
|
Assignee | |
Updated•6 years ago
|
Summary: Remove more code related to tree[seltype="cell|text"] → Remove platform code related to tree[seltype="cell|text"]
|
|
Assignee | |
Comment 4•6 years ago
|
||
|
||
Updated•6 years ago
|
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
|
|
||
Comment 5•6 years ago
|
||
Just to confirm, this removal should only affect consumers of tree[seltype="cell|text"], which as per https://bugzilla.mozilla.org/show_bug.cgi?id=1471542#c0 and https://bugzilla.mozilla.org/show_bug.cgi?id=1471542#c9 are unused in m-c and TB, right?
Flags: needinfo?(ntim.bugs)
|
|
Assignee | |
Comment 6•6 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #5)
> Just to confirm, this removal should only affect consumers of
> tree[seltype="cell|text"], which as per
> https://bugzilla.mozilla.org/show_bug.cgi?id=1471542#c0 and
> https://bugzilla.mozilla.org/show_bug.cgi?id=1471542#c9 are unused in m-c
> and TB, right?
Yes. This simply undoes https://github.com/mozilla/gecko-dev/commit/e5158d88eff369883b9fa994276d0b06cfe7ca8f which implemented tree[seltype="cell|text"] that's no longer used in m-c or TB.
Flags: needinfo?(ntim.bugs)
|
|
Assignee | |
Comment 7•6 years ago
|
||
ni? myself to find time to fix the test failures from comment 4.
Flags: needinfo?(ntim.bugs)
|
|
Assignee | |
Updated•6 years ago
|
Flags: needinfo?(ntim.bugs)
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9a4db52c22c2
Remove remains of tree cell-based selection code. r=bzbarsky,bgrins
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
|
|
Assignee | |
Updated•5 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•