Closed Bug 1508142 Opened 11 months ago Closed 11 months ago

Remove platform code related to tree[seltype="cell|text"]

Categories

(Core :: XUL, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I looked again at bug 1430374 and I realized that there is some code that I forgot to remove, see:

https://searchfox.org/mozilla-central/diff/e5158d88eff369883b9fa994276d0b06cfe7ca8f/toolkit/content/widgets/tree.xml#240

That diff contains everything that needs to be reversed.
(In reply to Tim Nguyen :ntim (please use needinfo?) from comment #0)
> I looked again at bug 1430374

I meant bug 1471542
Blocks: 1471542
No longer blocks: 1430374
Component: XUL Widgets → XUL
Product: Toolkit → Core
Summary: Remove more code related to tree[seltype="cell|text"] → Remove platform code related to tree[seltype="cell|text"]
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Just to confirm, this removal should only affect consumers of tree[seltype="cell|text"], which as per https://bugzilla.mozilla.org/show_bug.cgi?id=1471542#c0 and https://bugzilla.mozilla.org/show_bug.cgi?id=1471542#c9 are unused in m-c and TB, right?
Flags: needinfo?(ntim.bugs)
(In reply to Brian Grinstead [:bgrins] from comment #5)
> Just to confirm, this removal should only affect consumers of
> tree[seltype="cell|text"], which as per
> https://bugzilla.mozilla.org/show_bug.cgi?id=1471542#c0 and
> https://bugzilla.mozilla.org/show_bug.cgi?id=1471542#c9 are unused in m-c
> and TB, right?

Yes. This simply undoes https://github.com/mozilla/gecko-dev/commit/e5158d88eff369883b9fa994276d0b06cfe7ca8f which implemented tree[seltype="cell|text"] that's no longer used in m-c or TB.
Flags: needinfo?(ntim.bugs)
ni? myself to find time to fix the test failures from comment 4.
Flags: needinfo?(ntim.bugs)
Flags: needinfo?(ntim.bugs)
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9a4db52c22c2
Remove remains of tree cell-based selection code. r=bzbarsky,bgrins
Blocks: 1509377
https://hg.mozilla.org/mozilla-central/rev/9a4db52c22c2
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Depends on: 1513329
Depends on: 1513349
No longer depends on: 1513329
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.