1513401 - Graphite text highlighting does not have enough contrast on light background

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

With the 66 update, when you highlight or select text in a page, in a text field, or in the addressbar, the highlighting is barely visible.

Comment 1

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Not sure if this is limited to Mojave or whether it goes across other macOS versions.

Comment 2

[Tim Nguyen :ntim]

Could you please provide a screenshot ?

Comment 3

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Attachment: low-contrast-highlight-comment.png

Comment 4

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Attachment: low-contrast-highlight-addressbar.png

only the bug number is highlighted here

Comment 5

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Attachment: darker-highlight-in-64-beta.png

In 64 I could see visual feedback of what is highlighted.

Comment 6

[Tim Nguyen :ntim]

Thanks! Sounds like what I mentioned in bug 1486204 comment 59. I guess I can special case colors with 0% saturation and do some extra processing there, since multiplying up 0% saturation [0] won't do anything.

[0]: https://searchfox.org/mozilla-central/rev/3160ddc1f0ab55d230c595366662c62950e5c785/widget/cocoa/nsLookAndFeel.mm#157

Comment 7

[Markus Stange [:mstange]]

Yeah that sounds reasonable.

Comment 8

[Tim Nguyen :ntim]

Attachment: Bug 1513401 - Increase contrast of unsaturated selection colors in nsLookAndFeel.mm. r=mstange

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c2d55d510a7
Increase contrast of unsaturated selection colors in nsLookAndFeel.mm. r=mstange

Comment 10

[Tim Nguyen :ntim]

Comment on attachment 9031462 [details]
Bug 1513401 - Increase contrast of unsaturated selection colors in nsLookAndFeel.mm. r=mstange

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1486204

User impact if declined: Graphite selection color is faded out on light themes

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: See previous comments

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Self contained widget/cocoa change

String changes made/needed:

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2c2d55d510a7

Comment 12

[Markus Stange [:mstange]]

> +    value = 255 - (255 - value) * factor;

I realized a problem in the math: if value is less that 128, this will be 255 - [something larger than 255], which will be negative and then wraparound into a large uint16_t value when assigned to "value". So I think the "(255 - value) * factor" part should be wrapped in a mozilla::clamped(..., 0, 255).

This is not that urgent to fix because macOS does not, as far as I know, have gray highlighting colors that are darker than 128. But it should still be fixed.

Comment 13

[Tim Nguyen :ntim]

(In reply to Markus Stange [:mstange] from comment #12)
> > +    value = 255 - (255 - value) * factor;
> 
> I realized a problem in the math: if value is less that 128, this will be
> 255 - [something larger than 255], which will be negative and then
> wraparound into a large uint16_t value when assigned to "value". So I think
> the "(255 - value) * factor" part should be wrapped in a
> mozilla::clamped(..., 0, 255).
> 
> This is not that urgent to fix because macOS does not, as far as I know,
> have gray highlighting colors that are darker than 128. But it should still
> be fixed.

Filed bug 1514464, thanks!

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9031462 [details]
Bug 1513401 - Increase contrast of unsaturated selection colors in nsLookAndFeel.mm. r=mstange

[Triage Comment]
Fixes faded selection color when using a light theme on macOS. Approved for 65.0b5.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7cc9c0386e87

Comment 16

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello all,

This issue is verified fixed using Firefox 65.0b5 and the latest Nightly 66.0a1 (2018-12-17)on macOS 10.14(Mojave).