Selection color not visible on dark background on macOS
Categories
(Core :: Widget: Cocoa, defect, P2)
Tracking
()
People
(Reporter: ardacebi1, Assigned: ntim)
References
Details
(Keywords: regression)
Attachments
(5 files, 3 obsolete files)
Comment 1•6 years ago
|
||
Updated•6 years ago
|
Comment 3•6 years ago
|
||
Comment 4•6 years ago
|
||
Comment 7•6 years ago
|
||
Comment 8•6 years ago
|
||
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 12•6 years ago
|
||
Comment 15•6 years ago
|
||
Comment 16•6 years ago
|
||
Comment 17•6 years ago
|
||
Assignee | ||
Comment 18•6 years ago
|
||
Comment 19•6 years ago
|
||
Comment 20•6 years ago
|
||
Updated•6 years ago
|
Comment 21•6 years ago
|
||
Assignee | ||
Comment 22•6 years ago
|
||
Comment 23•6 years ago
|
||
Assignee | ||
Comment 24•6 years ago
|
||
Assignee | ||
Comment 26•6 years ago
|
||
Updated•6 years ago
|
Comment 27•6 years ago
|
||
Assignee | ||
Comment 28•6 years ago
|
||
Comment 29•6 years ago
|
||
Comment 30•6 years ago
|
||
Assignee | ||
Comment 31•6 years ago
|
||
Comment 32•6 years ago
|
||
Comment 33•6 years ago
|
||
Comment 34•6 years ago
|
||
Assignee | ||
Comment 36•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Comment 37•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 38•6 years ago
|
||
Assignee | ||
Comment 39•6 years ago
|
||
Assignee | ||
Comment 40•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 41•6 years ago
|
||
Assignee | ||
Comment 42•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 43•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 44•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 45•6 years ago
|
||
Assignee | ||
Comment 46•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Comment 47•6 years ago
|
||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Comment 48•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 52•6 years ago
|
||
Comment 53•6 years ago
|
||
Assignee | ||
Comment 54•6 years ago
|
||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Comment 56•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Comment 57•6 years ago
|
||
Comment 58•6 years ago
|
||
bugherder |
Assignee | ||
Comment 59•6 years ago
|
||
Comment 60•6 years ago
|
||
Comment 61•6 years ago
|
||
bugherder uplift |
Updated•6 years ago
|
Comment 62•6 years ago
|
||
Updated•6 years ago
|
Comment 64•6 years ago
|
||
This patch makes selection color oversaturated when gfx.color_management.mode = 1
Comment 65•6 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #61)
https://hg.mozilla.org/releases/mozilla-beta/rev/28756c341f02
It seems alpha channel then lost (I think here https://dxr.mozilla.org/mozilla-central/rev/7e40e33da3da2640e965a153254594a234231f76/widget/nsXPLookAndFeel.cpp#889-896) which gives result from previous comment.
Assignee | ||
Comment 66•6 years ago
|
||
(In reply to perumeni from comment #65)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #61)
https://hg.mozilla.org/releases/mozilla-beta/rev/28756c341f02
It seems alpha channel then lost (I think here https://dxr.mozilla.org/mozilla-central/rev/7e40e33da3da2640e965a153254594a234231f76/widget/nsXPLookAndFeel.cpp#889-896) which gives result from previous comment.
Thanks for figuring this out!
Markus, Is this something we should fix ? I'm not sure what gfx.color_management.mode = 1
does, but it does look broken with it flipped on.
Updated•6 years ago
|
Comment 67•6 years ago
|
||
Yes, perumeni identified exactly the right place. That code should be fixed to apply the original alpha to the color-corrected color.
Assignee | ||
Comment 68•6 years ago
|
||
I filed bug 1547353
Description
•