1513449 - Port bug 1415483 - changes to reject-importGlobalProperties rule

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1513449-eslint-1.diff

My m-c tree isn't up-to-date and I don't want to update it soon, so please check this passes.

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1513449-eslint-1.diff

Here was one more. Why does need to be taken out? I don't see them in the M-C changeset:
https://hg.mozilla.org/mozilla-central/rev/2d59d8c885a3

Also, why this?
-this.EXPORTED_SYMBOLS = ["MailInstrumentation"];
-
Doesn't anybody use that?

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1513449-eslint-1.diff

OK, put this.EXPORTED_SYMBOLS = ["MailInstrumentation"]; back.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/999ba6d634bb
Port bug 1415483: changes to reject-importGlobalProperties rule. r=jorgk DONTBUILD

Comment 5

[Jorg K (CEST = GMT+2)]

This was build on the same revision as the previous M-C push, so it's clear that this caused the following test failures:
TEST-UNEXPECTED-FAIL | comm/mail/components/extensions/test/xpcshell/test_ext_cloudFile.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | comm/mail/components/extensions/test/xpcshell/test_ext_cloudFile.js | - 2153066778 == 0
TEST-UNEXPECTED-FAIL | comm/mail/components/extensions/test/xpcshell/test_ext_cloudFile.js | - A promise chain failed to handle a rejection: [Exception... "Abort" nsresult: "0x80004004 (NS_ERROR_ABORT)" location: "JS frame :: Z:\\task_1544611658\\build\\tests\\xpcshell\\head.js :: _abort_failed_test :: line 757" data: no] - stack: _abort_failed_test@Z:\\task_1544611658\\build\\tests\\xpcshell\\head.js:757:9
TEST-UNEXPECTED-FAIL | comm/mail/components/extensions/test/xpcshell/test_ext_cloudFile.js | - Extension left running at test shutdown - "running" == "unloaded"

Let's see what happens if we put it back:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=1ba1035311fb6f245d405d72231aff8d5fadf48e

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9113e787783c
Restore |Cu.importGlobalProperties([File, FileReader]);| in ext-cloudFile.js. rs=bustage-fix

Comment 7

[Geoff Lankow (:darktrojan)]

I saw this bit last night and I don't understand why. Have you any insight, Mark?

Comment 8

[Mark Banner (:standard8)]

The webidl interfaces are now imported into jsm scope - as well as the window scope which is why we don't need most of these calls now. The content process still needs these calls so we've had to whitelist those in a few places (unfortunately scope detection is hard to do correctly).

My best guess is that something is being loaded in the content process and still needs one of the importGlobalProperties calls. I'm a bit surprised by ext-cloudFile.js as it seems to be in the parent process, but there could be sandboxing or something going on with that extension file.

Hopefully at some stage we'll be able to get rid of all the calls completely, but we'll have to wait and see on the next steps.