1513583 - Fix/enable ESLint React accessibility rules

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement, P1)

Description

[Ed Morley [:emorley]]

The following are currently disabled since existing code instances need fixing first:

https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/click-events-have-key-events.md
https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/label-has-associated-control.md
https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/label-has-for.md
https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-noninteractive-element-interactions.md
https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-static-element-interactions.md

Comment 1

[Ed Morley [:emorley]]

Missed one:
https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-is-valid.md

Comment 2

[Sarah Clements [:sclements]]

Since Draci has done a lot of work with the eslint rules, we'll merge their pull request after a few changes have been made.

Comment 3

[Shivansh Srivastava]

Can I help with this issue?

Comment 4

[Sarah Clements [:sclements]]

This has already been worked on, and it's assigned. Please look for a bug that is marked as "New" and doesn't have an assignee. Also good to search for bugs with the keyword "good first bug".

Comment 5

[Sarah Clements [:sclements]]

I'm giving this bug to mellinay since the topic is part of her internship and I wasn't able to merge :Draci's pr. If she doesn't get to it, then I'll open it up for someone else to work on.

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/6021