1531243 - [a11y] Various unlabelled buttons and missing roles

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P1)

Description

[James Teh [:Jamie]]

These are a bunch of small (but nevertheless annoying) issues, so I thought I'd file them in a single bug rather than filing several little tiny bugs. Let me know if any of them need to be split out.

The following elements have no label. They have title attributes, but the content overrides the title for a11y. This can be fixed with an aria-label attribute.

• Cancel all jobs (.cancel-all-jobs-btn)
• Unwatch (.watched-repo-unwatch-btn). Probably also applies to other watch related buttons, but I couldn't make this happen at time of writing.
• Open the raw log in a new window (.raw-log-icon)

The following elements have no role. They should get role="button" or similar (or they should be native HTML controls).

• Login/register
• Add this job to the pinboard (#pin-job-btn)
• Repeat the selected job (#retrigger-btn)
• Other job actions (#actionbar-menu-btn)

Comment 1

[James Teh [:Jamie]]

One more button that needs a role:

• PinBoard (#pinboard-btn)

Comment 2

[Ed Morley [:emorley]]

Hi! Thank you for the detailed bug report - that's really helpful. Sorry we're missing these.

Sarah, would you mind taking a look at this? I suspect fixing this would get us most of the way towards being able to enable the rest of the ESLint React accessibility rules (bug 1513583).

Comment 3

[Sarah Clements [:sclements]]

I've got too much on my plate at the moment, so passing to Cameron :)

Comment 4

[Cameron Dawson [:camd]]

Sure, I can take this.

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4731

Comment 6

[Cameron Dawson [:camd]]

I believe this will also fix Bug 1532049

Comment 7

[Cameron Dawson [:camd]]

This should head out to treeherder.allizom.org shortly. Then will go to production on our next prod push.