1513878 - Implement a getter method to WindowGlobalParent/WindowGlobalChild

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[John Dai[:jdai]]

https://docs.google.com/document/d/1ALC8TxBy4pfS2tzI8Mb8Z3Nr5dzSjYYPSQxMn00_aWE/edit?ts=5bf786b3

Comment 1

[John Dai[:jdai]]

This bug will provide a getter method from WindowGlobalParent/WindowGlobalChild.

[ChromeOnly]
partial interface WindowGlobalParent {
// Getter method added to WindowGlobalParent. When called looks up the 
// corresponding actor, constructs it if it hasn't been constructed yet, 
// and returns it.
[Throws]
WindowActorParent getActor(DOMString name);
};

[ChromeOnly]
partial interface WindowGlobalChild {
// Getter method added to WindowGlobalParent. When called looks up the 
// corresponding actor, constructs it if it hasn't been constructed yet, 
// and returns it.
[Throws]
WindowActorChild getActor(DOMString name);
};

Comment 2

[John Dai[:jdai]]

Summarize the current status, the bug needs to do the following things:

1. Looks up the corresponding actor.
2. Constructed it if it hasn't been constructed yet.
   2a. Load module URI.
   2b. Construct the actor.
3. Return the actor.

I'm working on 2b. In 2b, I was trying two different ways to construct an actor. The first way, I want to get constructor from module's export, then call the constructor to create an object instance. However, I can't get constructor from module's export. I guess it's because the module's export only has the class declaration, not the instance of the class, so there is no constructor's function object. The second way, I want to get class from module's export, then create an object instance by the class. However, I use JS_NewObject to create an object instance, the prototype is undefined. If I'm in the wrong direction, please let me know.

Comment 3

[John Dai[:jdai]]

Nika pointed out that I missed adding [Constructor] in webidl. That is the main reason that calls the constructor to create an object instance doesn't work[1].

[1] https://heycam.github.io/webidl/#Constructor

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4f787d9a250126e893e8c28d04333bb91de4142

Comment 4

[John Dai[:jdai]]

Attachment: Bug 1513878 - Implement a getter method to WindowGlobalParent/WindowGlobalChild.

Comment 5

[John Dai[:jdai]]

GetWindowGlobalChild[1] should be exposed to webidl so that the test case can get an actor from the child side. Retrieve the review request, I will update the patches and send a review again.

[1] https://searchfox.org/mozilla-central/source/dom/base/nsPIDOMWindow.h#367

Comment 6

[John Dai[:jdai]]

Attachment: Bug 1513878 - Part 1: Expose window global child to window.

Comment 7

[John Dai[:jdai]]

Attachment: Bug 1513878 - Part 2: Implement a getter method to WindowGlobalParent/WindowGlobalChild.

Depends on D16844

Comment 8

[John Dai[:jdai]]

Attachment: Bug 1513878 - Part 3: Add getActor test for WindowGlobalParent/WindowGlobalChild.

Depends on D16845

Comment 9

[John Dai[:jdai]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&tier=1&revision=0803ef12b2bc4efc5c667e4c684f9ffbb50e3f26&group_state=expanded

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48b36980fe1c
Part 1: Expose window global child to window. r=nika
https://hg.mozilla.org/integration/autoland/rev/0333640041bb
Part 2: Implement a getter method to WindowGlobalParent/WindowGlobalChild. r=nika
https://hg.mozilla.org/integration/autoland/rev/a480d92de046
Part 3: Add getActor test for WindowGlobalParent/WindowGlobalChild. r=nika

Comment 11

[Dorel Luca [:dluca]]

Backed out 3 changesets (bug 1513878) for build bustage. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=224075898&repo=autoland&lineNumber=18711

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=224075898&revision=a480d92de046edf8092ea9a3f0ed56a060aea8eb

Backout:
https://hg.mozilla.org/integration/autoland/rev/883b89f3a11f1416611a52cf015bcf4291739a6a

Comment 12

[John Dai[:jdai]]

It's only happened at Android 4.2 x86 debug, and errors show at
/builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/PaymentMethodChangeEvent.h:32:43: error: unknown type name 'ChangeDetails'
/builds/worker/workspace/build/src/obj-firefox/dom/bindings/PaymentMethodChangeEventBinding.cpp:279:15: error: cannot initialize object parameter of type 'const mozilla::dom::Event' with an expression of type 'mozilla::dom::PaymentMethodChangeEvent'
/builds/worker/workspace/build/src/obj-firefox/dom/bindings/PaymentMethodChangeEventBinding.cpp:587:14: error: static_cast from 'mozilla::dom::PaymentMethodChangeEvent *' to 'mozilla::dom::PaymentRequestUpdateEvent *', which are not related by inheritance, is not allowed
/builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/BindingUtils.h:2424:14: error: no matching member function for call to 'PreserveWrapper'
/builds/worker/workspace/build/src/obj-firefox/dist/include/nsISupportsUtils.h:121:3: error: static_assert failed "don't use CallQueryInterface for compile-time-determinable casts"
/builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/BindingUtils.h:982:19: error: cannot initialize object parameter of type 'const nsWrapperCache' with an expression of type 'mozilla::dom::PaymentMethodChangeEvent'
/builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/BindingUtils.h:1608:37: error: cannot initialize object parameter of type 'mozilla::dom::Event' with an expression of type 'mozilla::dom::PaymentMethodChangeEvent'
/builds/worker/workspace/build/src/obj-firefox/dist/include/nsCycleCollectionNoteChild.h:46:52: error: cannot initialize a parameter of type 'mozilla::dom::Event *' with an lvalue of type 'mozilla::dom::PaymentMethodChangeEvent *'

Comment 13

[John Dai[:jdai]]

Attachment: Bug 1513878 - Part 1: Expose window global child to window.

Comment 14

[John Dai[:jdai]]

Attachment: Bug 1513878 - Part 2: Implement a getter method to WindowGlobalParent/WindowGlobalChild.

Depends on D17826

Comment 15

[John Dai[:jdai]]

Attachment: Bug 1513878 - Part 3: Add getActor test for WindowGlobalParent/WindowGlobalChild.

Depends on D17827

Comment 16

[John Dai[:jdai]]

Attachment: Bug 1513878 - Part 4: Fix build fail for android 4.2 x86 debug build-android-x86-fuzzing/debug.

Depends on D17828

Comment 17

[John Dai[:jdai]]

Attachment: Bug 1513878 - Part 4: Fix build fail for android 4.2 x86 debug build-android-x86-fuzzing/debug.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/845c2f0d18b5
Part 1: Expose window global child to window. r=nika
https://hg.mozilla.org/integration/autoland/rev/d7289306549f
Part 2: Implement a getter method to WindowGlobalParent/WindowGlobalChild. r=nika
https://hg.mozilla.org/integration/autoland/rev/640f4072f19a
Part 3: Add getActor test for WindowGlobalParent/WindowGlobalChild. r=nika

Comment 19

[John Dai[:jdai]]

(In reply to John Dai[:jdai] from comment #12)

The problem is that PaymentMethodChangeEvent.h[1] doesn't include header file for ChangeDetails.

[1] https://searchfox.org/mozilla-central/rev/4faab2f1b697827b93e16cb798b22b197e5235c9/dom/payments/PaymentMethodChangeEvent.h#51

Comment 20

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/845c2f0d18b5
https://hg.mozilla.org/mozilla-central/rev/d7289306549f
https://hg.mozilla.org/mozilla-central/rev/640f4072f19a