1513935 - PARENT_IS_LOADING_OR_RUNNING_TIMEOUT missing

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Andreas Farre [:farre]]

There's no PARENT_IS_LOADING_OR_RUNNING_TIMEOUT[1] in nsIWindowCreator2[2] as far as I can tell

[1] https://searchfox.org/comm-central/search?q=PARENT_IS_LOADING_OR_RUNNING_TIMEOUT&path=
[2] https://searchfox.org/comm-central/source/mozilla/toolkit/components/windowcreator/nsIWindowCreator2.idl

I discovered this while looking at merging the types nsIWindowCreator2 and nsIWindowCreator (by removing nsIWindowCreator essentially).

Comment 1

[Frank-Rainer Grahl (:frg)]

This was removed in Bug 1321270 which we never backported.

Comment 2

[Frank-Rainer Grahl (:frg)]

To test the functionality: Set dom.disable_open_during_load to false and load a site opening a popup during load. The popup window will have a popup menu allowing you the reject popups from this site in 2.49.x. The option was removed in Gecko 53 so the current 2.53.x version will never show the menu items reject or allow popups.

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: 1513935-nsIWindowCreator2-2537.patch

My proposal is to kill the code and not trying to make it work somehow:

• Not working for all 2.53 releases and no one complained / missed it.
• Non default setting and not really recommended to always allow popups.
• With Tools->Popup Manager we have a replacement. Just needs to be enabled not depending on the dom load config setting. The permissions work either way.

[Approval Request Comment]
Regression caused by (bug #): 1321270
User impact if declined: no one noticed so far that this is broken.
Testing completed (on m-c, etc.): 2.53.7
Risk to taking this patch (and alternatives if risky): just dumbing down code.
String changes made by this patch: Some removals.

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: 1513935-nsIWindowCreator2-2537.patch

Previous one wasn' t the latest version.

Comment 5

[Ian Neal]

Comment on attachment 9198873 [details] [diff] [review]
1513935-nsIWindowCreator2-2537.patch

>+++ b/suite/browser/navigator.js
>+function CheckForVisibility(aEvent, aNode) {
>   CheckPermissionsMenu("popup", aNode);
> }
Rather than keep this function, just change the caller in navigatorOverlay.xul to use CheckPermissionsMenu instead.

r/a=me with that addressed.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/126319db450b
Remove usage of PARENT_IS_LOADING_OR_RUNNING_TIMEOUT contextFlag. r=ianN

Comment 7

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/6415f7124c58dec8afa38db6627f5e4b57ee317e
Remove usage of PARENT_IS_LOADING_OR_RUNNING_TIMEOUT contextFlag. r=ianN a=IanN
Target 2.53.7