1514018 - Create a hero unit section component for Activity Stream experiment functionality

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P2)

Description

[Scott [:thecount] Downe]

We need this to be something we can turn on and off, and can land in nightly 66 without breaking any existing functionality.

It needs designs still, but I can attach wire frames.

Comment 1

[Scott [:thecount] Downe]

Attachment: hero.png

Comment 2

[Gavin Suntop [:gvn] (they/them)]

Landed progress in https://github.com/mozilla/activity-stream/pull/4644

• enforce image aspect ratios
• wire up links & add interaction states (active/focus/hover)
• generally tighten up styling
• set count of cards based on remote layout definition
• enforce character counts

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4653

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/226b130b6360

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/915ef9df72e0f4de333aa41a728f049d4be43f60
Bug 1514018 - Hero component refinement (WIP) (#4653)

- enforce image aspect ratios
- wire up links & add interaction states (active/focus/hover)
- generally tighten up styling
- set count of cards based on remote layout definition
- enforce character counts

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/8de26a67ac5c

Comment 7

[Brahmini Nagabandi]

Hi,

Any updates on QA steps.

Thanks,
Brahmini

Comment 8

[Gavin Suntop [:gvn] (they/them)]

QA Steps

Set browser.newtabpage.activity-stream.discoverystream.config to {"enabled":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-1"}

Open new tab and look at Hero component to verify

• enforced image aspect ratios (see Figma)
• wired up links & add interaction states (active/focus/hover) (see Figma)
• set count of cards based on remote layout definition (this layout has 3)
• enforced character counts (see Figma)

Comment 9

[Brahmini Nagabandi]

Item title isn't highlighted when hovered anywhere within Hero section

Tracking issue here : https://bugzilla.mozilla.org/show_bug.cgi?id=1521643

Comment 10

[Brahmini Nagabandi]

QA Results :

Tested on :

FF Nightly version : 66.0a1 (2019-01-20)

OS : Mac and Windows 10 Pro

Closing as verified as the issue is being tracked separately bug 1521643

However, the entire experiment should be re-tested once the issue is fixed.