Closed Bug 1521643 Opened 5 years ago Closed 5 years ago

Hover : Item title isn't highlighted when hovered anywhere within Hero section

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 66
Iteration:
66.4 - Jan 21 - 27
Tracking Status
firefox66 --- fixed

People

(Reporter: bnagabandi, Assigned: gsuntop)

References

()

Details

(Keywords: github-merged)

Attachments

(1 file)

Tested on :

FF Nightly version : 66.0a1 (2019-01-20)

OS : Mac and Windows 10 Pro

Depends on the bug https://bugzilla.mozilla.org/show_bug.cgi?id=1514018

Steps to Reproduce:

  1. Go to Config and Set browser.newtabpage.activity-stream.discoverystream.config to {"enabled":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-1"}
  2. Open new tab
  3. Observe Hover interactions
    Bug :
    • Hover works as expected only when placed on the item title.
    • Hover anywhere within the item section. Hover on the excerpt or on image or on the `publisher/sponsor'. Wiredup link is not highlighted.

Expected Result:
Hover anywhere within the item section. Hover on the image title excerpt or on image or on the `publisher/sponsor' should Highlight the image title

Summary: Hover : Item title isn't highlighted when hovered over the entire Hero section → Hover : Item title isn't highlighted when hovered anywhere within Hero section
Assignee: nobody → gsuntop
Iteration: --- → 66.4 - Jan 21 - 27
Priority: -- → P1
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/7e8b5097d7e0a7423db44b99242c6f5511db4c16
Bug 1521643 – Item title highlights when hovering anywhere within Hero section (#4704)
Blocks: 1522379
Keywords: github-merged
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66

QA Results:

Tested on :

FF Nightly version : 66.0a1 (2019-01-25)
OS : Mac and Windows 10 Pro

Test steps :

In about:config pref {"enabled":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"} has been set to {"enabled":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}

Looks good to me. Title color changes when the mouse is hovered anywhere over the entire item, not just when it's hovered over the title itself.

(Similar to bug 1519772)

closing as verified.

Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: