1514585 - Download Manager Windows should only flash if already open not honored

Status: RESOLVED FIXED

(SeaMonkey :: Download & File Handling, defect)

Description

[Joachim Otahal]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0 SeaMonkey/2.53

Steps to reproduce:

Start Seamonkey fresh (fresh profile, if you want).
Check Download Setting: Set to "Open download manager" + "Just flash the download manager if it is already open".
Go to any site.
Rightclick picture: download, save.
Download manager opens and is foreground.
Rightclick another picture: download, save.
The already open download manager gets put in foreground.


Actual results:

As for SM 2.49 (and all previous) the download manager only flashes when it is already open, but is not put foreground.
But with SM 2.53 it is put in foreground, so I need extra mouseclicks to activate the main seamonkey window again.


Expected results:

Download Manager should stay in background and only flash.

Comment 1

[Joachim Otahal]

Exact build Info:
User agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0 SeaMonkey/2.53
Build identifier: 20181210134801
Source: http://www.wg9s.com/
OS: Win10 x64 1809

Current ugly workaround with an autohotkey script:

#NoEnv  ; Recommended for performance and compatibility with future AutoHotkey releases.
;send Seamonkey download Manager to background (seamonkey 2.53 bug workaround)
Loop
{
  WinGet, Active_ID, ID, A
  WinGet, Active_Process, ProcessName, ahk_id %Active_ID%
  WinGetActiveTitle, Title
  ;Only on Seamonkey.exe
  If ( Active_Process ="seamonkey.exe" )
  {
    ;Only if DL-Manager is the active window
    IfInString, Title, Download Manager
    {
      ;Ignore if we actually click the DL-Manager to drag around
      ;Not needed, but prevents moving the DL-Manager as background window.
      if (GetKeyState("Lbutton") = 0)
      {
         SetTitleMatchMode, 2
         WinActivate, - SeaMonkey
      }
    }
  }
  Sleep, 25
}

Comment 2

[Frank-Rainer Grahl (:frg)]

Confirmed. Let me see if I can do something about it.

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: 1514585-DownloadManagerFlash.patch

The idl file was missing the download parameter for the show function. With nsIDownload gone and this not really using the wrapped js download during Manager startup I opted for a simple bool. This just indicates if a new download is started. All other cases are currently user interaction which should show the manager.

Will be in Bills next builds today or tomorrow too.

Comment 4

[Joachim Otahal]

That was quick. Will report success (tough not as fast as you fixed it).

Comment 5

[Ian Neal]

Comment on attachment 9031762 [details] [diff] [review]
1514585-DownloadManagerFlash.patch

a/r=me

Comment 6

[Joachim Otahal]

Confirmed: Fix works!

Comment 7

[bblack]

Build identifier: 20181216130004
Works with me too.
So fixed

Comment 8

[Frank-Rainer Grahl (:frg)]

bblack keep in mind that a fix in a WG9s build is not a fix here. No push no resolve. And it actually caused Bug 1514729.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5725e65df3d5
Fix missing idl parameter to only flash Download Manager when requested via pref. r=IanN

Comment 10

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/1a9745dedfae9199d010510f37b1a6d4b6f88e99

Comment 11

[Frank-Rainer Grahl (:frg)]

Give Bills build a day because of bug 1514729 and you can mark it verified again then :)