1514763 - Console input height is not updated

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

This is probably due to Bug 1502524

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

**Steps to reproduce**
1. Go to `data:text/html,<meta charset=utf8><script>for (var i = 0; i < 100; i++) console.log(i)</script>`
2. Open the console
3. In the console input, hit Shift+Enter to create a new line, the input height is modified accordingly
4. Hit backspace to remove the new line

**Expected results**

The console input is back to its original height (1 line height)

**Actual results**

The console input keeps its height

---

We should probably revert the patch made in Bug 1502524 as it's pretty small.

Comment 2

[Daniel Holbert [:dholbert]]

Darn - yeah, we should revert it. I had tested it a bit, but I guess not thoroughly enough. Thanks for catching this.

(If there's another wrapper-div involved here that doesn't care about the height of its content, then we may want to put 'contain' styling on that one instead, if it gives similar speedups to bug 1502524 comment 1.)

Comment 3

[Daniel Holbert [:dholbert]]

Actually, this might still be a good case for containment, and this setup is just uncovering a layout bug around containment and reflow roots...

In particular: if you perform the STR and then resize the window horizontally, then the console-input jumps back to the correct original height.  So it seems that the containment invariants aren't breaking things here, but rather a layout bug (a difference in reflow thoroughness) is breaking things.

Comment 4

[Daniel Holbert [:dholbert]]

Aha! In fact, technically, the containment styling on bug 1502524 should've broken things *more severely*.  But it didn't, due to an issue that I've filed as bug 1514843.

So yeah, we do need to back out bug 1502524.

Comment 5

[Daniel Holbert [:dholbert]]

I've backed out bug 1502524, so let's call this fixed-by-backout. (Technically not "fixed" until that bug merges to central, but that'll happen soon enough.)