Closed Bug 1515004 Opened 2 years ago Closed 2 years ago
Move Android SDK detection to moz
47 bytes, text/x-phabricator-request
|Details | Review|
Also, ./mach bootstrap installs android SDK to ~/.mozbuild/, so we should detect Android SDK automatically without --with-android-sdk if installing by ./mach bootstrap.
(In reply to Makoto Kato [:m_kato] (PTO 12/21-1/3, so slow resoponse) from comment #0) > Also, ./mach bootstrap installs android SDK to ~/.mozbuild/, so we should > detect Android SDK automatically without --with-android-sdk if installing > by ./mach bootstrap. Mmm, you're right -- we should make MOZ_STATE_DIR (~/.mozbuild) the default location. I'd really prefer to use the Android SDK from Android Studio, if possible -- see Bug 1221253 -- and, IIRC, we don't actually require the Android SDK directly any more -- see Bug 1498406! So yes, I'd like to do this, but there are other things to consider as well. Thanks for filing!
For Windows support (not WSL), I would like to move --with-adnroid-sdk to moz.configure. Since ./mach bootstrap installs Android SDK into ~/.mozbuild, we should detect this location as default SDK install path. Also, --with-android-max-sdk and --with-android-min-sdk are still in android.m4 because confvars.sh sets MOZ_ANDROID_MIN_SDK_VERSION.
2 years ago
Assignee: nobody → m_kato
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/b2a43f0c9d78 Move --with-android-sdk to moz.configure. r=nalexander
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 67 → mozilla67
You need to log in before you can comment on or make changes to this bug.