Closed Bug 1515174 Opened Last year Closed Last year

Preferences pane is cut off at the bottom after restart

Categories

(Thunderbird :: Preferences, defect)

Product:
Thunderbird
Component:
Preferences
Type:
defect
Priority:
Not set

Tracking

(thunderbird65 fixed, thunderbird66 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 66.0
Tracking Flags:
Tracking Status
thunderbird65 --- fixed
thunderbird66 --- fixed

People

(Reporter: jorgk-bmo, Assigned: darktrojan)

Details

Attachments

(1 file)

1515174-preferences-height-1.diff
5.23 KB, patch
jorgk-bmo
: review+
jorgk-bmo
: approval-comm-beta+
Details | Diff | Splinter Review 
STR:

Tools > Preferences. Select "General" or "Advanced, General".
Restart TB.
The selected Preferences pane comes back, but the content is cut off at the bottom. For "General" the "Browse" button and the sound file box are cut off, for "Advanced, General" it's the "Config Editor" button.
Flags: needinfo?(geoff)
Flags: needinfo?(acelists)
I'm not the only one seeing this? Good. I *think* I know what can be done about it.
Flags: needinfo?(geoff)
Yes, also on Linux.
Flags: needinfo?(acelists)
Assignee: nobody → geoff
Status: NEW → ASSIGNED
It appears this wrapping box has existed since the dawn of time (hg@1) and does nothing useful. Removing it also means this binding could be de-XBL-ified.
Attachment #9032262 - Flags: review?(jorgk)
Comment on attachment 9032262 [details] [diff] [review]
1515174-preferences-height-1.diff

Thanks, that works. So taking old cruft out makes things work, nice :-)

I can't understand how you can remove flex="1" from chat.inc.xul. It's not there and never was there.
Attachment #9032262 - Flags: review?(jorgk) → review+
(In reply to Jorg K (GMT+1) from comment #4)
> I can't understand how you can remove flex="1" from chat.inc.xul. It's not
> there and never was there.
Hmm, you're adding this in bug 1514632. So that one might need a rebase now.
Oh right, I wrote this patch on top of that patch. So this one might need a rebase now.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e2b8bf66d263
Remove unnecessary box wrapping pref pane contents. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Is that broken in TB 65 beta?
Target Milestone: --- → Thunderbird 66.0
Comment on attachment 9032262 [details] [diff] [review]
1515174-preferences-height-1.diff

Yes it is.
Attachment #9032262 - Flags: approval-comm-beta?
Attachment #9032262 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.