Closed Bug 1515176 Opened 5 years ago Closed 5 years ago

Restrict access to APIs where a manifest key is required

Categories

(Thunderbird :: Add-Ons: Extensions API, defect)

Product:
Thunderbird
Component:
Add-Ons: Extensions API
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 66.0

People

(Reporter: darktrojan, Assigned: darktrojan)

Details

Attachments

(1 file)

1515176-manifest-permission-1.diff
2.84 KB, patch
mkmelin
: review+
Details | Diff | Splinter Review 
I discovered yesterday that I could do this. It should be done.

        Attachment #9032249 -
        Flags: review?(mkmelin+mozilla)

    
    

    
  
Can you explain what it does?

    
    

    
  
Without it, every WebExtension has access to browser.browserAction (for example), even if that makes no sense. Only WebExtensions that have a browser action (defined in the manifest) should be see browser.browserAction. That's what it does.

        Attachment #9032249 -
        Flags: review?(mkmelin+mozilla) → review+

    
  
Keywords: checkin-needed

    
    

    
  
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/3df0e93306f9
Restrict access to APIs where a manifest key is required; r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

    
  
Target Milestone: --- → Thunderbird 66.0

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: