1515248 - Upgrade Android-Gradle plugin to 3.2.1+

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, enhancement, P2)

Description

[Nick Alexander :nalexander [he/him]]

This will support a smooth Gradle composite build for upstream consumers including the Reference Browser and Focus.  Those projects both use Android-Gradle 3.2.1; if we can make GeckoView use the same version, we can get the benefits of flows like https://mozilla.github.io/application-services/docs/applications/working-with-reference-browser.html.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1515248 - Upgrade to Android-Gradle plugin 3.2.1 and build-tools 28.0.3.

This turned out to be easier than I anticipated.  There are new
warnings:

 0:29.89 > Task :app:mergeWithoutGeckoBinariesDebugResources
 0:30.38 /Users/nalexander/Mozilla/gecko/mobile/android/services/src/main/res/layout/fxaccount_status_error_preference.xml:17: warn: generated id 'android:id/icon' for external package 'android'.
 0:30.38 /Users/nalexander/Mozilla/gecko/mobile/android/services/src/main/res/layout/fxaccount_status_error_preference.xml:49: warn: generated id 'android:id/summary' for external package 'android'.
 0:30.38 /Users/nalexander/Mozilla/gecko/mobile/android/services/src/main/res/layout/fxaccount_status_error_preference.xml:37: warn: generated id 'android:id/title' for external package 'android'.
 0:30.38 /Users/nalexander/Mozilla/gecko/mobile/android/services/src/main/res/layout/fxaccount_status_error_preference.xml:60: warn: generated id 'android:id/widget_frame' for external package 'android'.

https://stackoverflow.com/a/49268877 suggests these are errors in the
Android Support library.  This particular piece of UI isn't hard to
navigate to; I will verify that it isn't busted before landing.

Comment 2

[Nick Alexander :nalexander [he/him]]

I'm just noting here that findbugs jobs, like at https://taskcluster-artifacts.net/WuB4opHfSVarH5J-p-1Vfg/0/public/logs/live_backing.log, warn about not finding Android classes right now.  I'm going to fix this while I'm in the area.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:nalexander, could you have a look please?

Comment 5

[Nick Alexander :nalexander [he/him]]

GeckoView team, I'm concerned that we are exposed to significant and increasing risk as the GeckoView build variants lag further and further behind mainline. We have seen "big bang" upgrades be required in the past, generally from Google by fiat, and if there is not incremental maintenance they can get very expensive. So I'd like to see a little focused effort on incremental upgrades.

To that end, I've rebased this but I'm not going to drive it across the line (without direction from my chain, I guess). This bogged down with lint changes (see also Bug 1512487, which I hope to land shortly) that aren't really relevant to the core upgrade. From here, there's a much longer jump to Android-Gradle 3.3+, and then I believe just a hop to Android-Gradle 3.4+.

Comment 6

[Nick Alexander :nalexander [he/him]]

Also: https://treeherder.mozilla.org/#/jobs?repo=try&revision=881654aeccbd1af31c6d6088f37994315b8a154f, which (with luck) is green except for A(lint).

Comment 7

[Chris Peterson [:cpeterson]]

P2 because this is important for developer ergonomics, but not an immediate blocker.

It will be easier to make this work just for GV when we no longer need to build Fennec. That will probably be in the Nightly cycle for 71 or 72.

Comment 8

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1515248 - Run android lints against GeckoView.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c85260bc434c
Run android lints against GeckoView. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/07168db23c56
Upgrade to Android-Gradle plugin 3.2.1 and build-tools 28.0.3. r=agi

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c85260bc434c
https://hg.mozilla.org/mozilla-central/rev/07168db23c56