47 bytes, text/x-phabricator-request
|Details | Review|
Bug 1436086 will make it possible to navigate to the overflow button on the nav bar if it's visible. However, pressing space or enter does nothing. The toolbar key nav code simulates a click event, but that doesn't work because the overflow button uses mousedown. Even if we fixed that, the panel doesn't get focus. This panel goes a step further in that pressing down arrow or tab doesn't even work to focus the first item. This is trivial to fix with a keypress handler. I already have the fix, but still need to write tests.
I'm fairly sure keyboard navigation in this menu is explicitly disabled because it can contain the search bar, and having a text input in the middle of arrow-navigated menus doesn't really work the way people expect. If you have a good idea about how to fix that, I'm all ears. There's also bug 1477673 and bug 1489974 and bug 1379387.
P1 given Jamie is working on this.
Priority: -- → P1
(In reply to :Gijs (he/him) from comment #1) > I'm fairly sure keyboard navigation in this menu is explicitly disabled > because it can contain the search bar, and having a text input in the middle > of arrow-navigated menus doesn't really work the way people expect. It's true that the behaviour with the search box and the arrow keys is currently ugly; if you cursor into the search box, you can't get out with the arrows. However, you *can* use the tab key instead (which is equivalent to the arrows in these panels). Given that there is a workaround, I think not having it usable with the keyboard at all is far worse than this ugliness. > If you have a good idea about how to fix that, I'm all ears. Three possibilities: 1. Somehow make it so that the down/up arrow keys get handled by PanelMultiView instead of the search box when there's no text entered in the search box, assuming this doesn't already do something. I guess this would mean tweaking the search box so that it doesn't eat the key events in this case. 2. Have PanelMultiView Only navigate to buttons with up/down arrows. The user would have to tab to get to the search box. Perhaps a bit confusing, but it does solve the problem. 3. Have PanelMultiView disable up/down arrows altogether if there's a text box. That said, I still think we should deal with this in a future bug.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/fa59aea64e12 Support keyboard activation (space/enter) of toolbar overflow buttons when focused. r=Gijs
Summary: Make browser toolbar overflow panels keyboard accessible → Make it possible to activate browser toolbar overflow panels from the keyboard
You need to log in before you can comment on or make changes to this bug.