Closed Bug 1515796 Opened 7 years ago Closed 6 years ago

Avoid constructing custom element and/or XBL binding code for <radio> in browser.xul on DOMContentLoaded to avoid the associated overhead

Categories

(Firefox :: General, enhancement, P3)

Product:
Firefox
Component:
General
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Tracking Flags:
Tracking Status
firefox-esr60 --- wontfix
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- fixed

People

(Reporter: Gijs, Assigned: bgrins)

References

(Depends on 1 open bug)

Details

(Whiteboard: [fxperf:p2][fixed by bug 1495861])

+++ This bug was initially created as a clone of Bug #1515795 +++ The overhead here is more minimal than for <tree>, bigger than for the search bar. I don't really even know where the radio elements are coming from...
No longer blocks: 1515795
See Also: → 1515795
Looks like this is caused by the panic button panel.
Summary: Avoid constructing UA widget and/or XBL binding code for <radio> in browser.xul on DOMContentLoaded to avoid the associated overhead → Avoid constructing custom element and/or XBL binding code for <radio> in browser.xul on DOMContentLoaded to avoid the associated overhead

Looking at this profile: https://perfht.ml/2SHz3l1

it looks like time spent constructing the radio elements is indeed far less than setting up the tree - although I wonder if this is because tree.js will have already caused a style flush to occur. At any rate, this seems like something worth fixing for start-up speed, but I wouldn't call it top priority just yet (unless it ends up causing a flush after the tree flush is fixed!)

Whiteboard: [fxperf] → [fxperf:p2]
Priority: -- → P3
Depends on: 1515799

This should be better now that bug 1495861 has landed.

Depends on: 1495861
Flags: needinfo?(gijskruitbosch+bugs)

I don't see anything in the instrumentation bug 1541516 added for radio and radio group elements, so I think this is fixed.

Assignee: nobody → bgrinstead
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66: affected → wontfix
status-firefox68: --- → fixed
Flags: needinfo?(gijskruitbosch+bugs) → qe-verify-
Resolution: --- → FIXED
Whiteboard: [fxperf:p2] → [fxperf:p2][fixed by bug 1495861]
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.