1515818 - Ensure cookie restrictions continues to block domains that have DNT annotations

Status: NEW

(Core :: Privacy: Anti-Tracking, enhancement, P3)

Description

[Steven Englehardt [:englehardt]]

The Disconnect list does not currently contain any real domains that are annotated with DNT tags. If the list were to have a real domain added, the list creation script would split the domain off into a separate list [0] (`baseeff-track-digest256` or `basew3c-track-digest256` depending on which version of DNT is respected).

To include the DNT domains, we'd need to update `urlclassifier.trackingAnnotationTable` to...

`test-track-simple,base-track-digest256,basew3c-track-digest256,baseeff-track-digest256` for the basic list and...

`test-track-simple,base-track-digest256,basew3c-track-digest256,baseeff-track-digest256,content-track-digest256,contenteff-track-digest256,contentw3c-track-digest256` for the strict list.

[0] see https://github.com/mozilla-services/shavar-list-creation-config/blob/2b15095d5cc802f7d93983eb719b9267d44a005b/prod.ini#L6-L19

Comment 1

[(no longer active)]

Is the work on the Gecko side just setting the pref to the right values?

Can the pref values be adjusted now, or do we need to wait for the list splitting to happen first on the server side?

Thanks!

Comment 2

[Steven Englehardt [:englehardt]]

> Is the work on the Gecko side just setting the pref to the right values?

Yes, setting `urlclassifier.trackingAnnotationTable` should be all that's needed as long as the list creation is working as expected. We'll also need to make sure this value is set correctly in whatever feature we end up using after the refactoring of the URL classifier happening in Bug 1513046.

> Can the pref values be adjusted now, or do we need to wait for the list splitting to happen first on the server side?

The lists are already split, though there's only one domain with a DNT value (a test domain) [0]. This gets split off into baseeff-track-digest256. Unfortunately we're not able to do an end-to-end test to verify that adding `baseeff-track-digest256` to the annotations pref actually starts blocking this domain because it appears to be one of the hardcoded domains [1] that is blocked regardless of the list settings. Fixing Bug 1514852 Comment 1 would make this kind of testing easier.

[0] https://github.com/mozilla-services/shavar-prod-lists/blob/6729917a6aa4ab7583b3154761aabfa013d20816/disconnect-blacklist.json#L8515-L8521
[1] https://searchfox.org/mozilla-central/rev/8a135a9c5a96b59269f544fcaee76d8fd5a7026a/toolkit/components/url-classifier/SafeBrowsing.jsm#487

Comment 3

[BugBot [:suhaib / :marco]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.