Closed Bug 1513046 Opened 7 years ago Closed 7 years ago

[meta] Port url-classifier clients to features

Categories

(Core :: DOM: Security, enhancement, P2)

Product:
Core
Component:
DOM: Security
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox66 --- affected

People

(Reporter: baku, Assigned: baku)

References

Details

(Keywords: meta, Whiteboard: [domsecurity-active])

Attachments

(3 files, 3 obsolete files)

part 4 - remove sync IPC call
13.77 KB, patch
Details | Diff | Splinter Review
part 5 - get feature by name
26.96 KB, patch
Details | Diff | Splinter Review
part 6 - remove asyncClassifyLocalWithTables
12.52 KB, patch
Details | Diff | Splinter Review
In order to give an overview of how I'm proceeding with the URL-classifier refactoring, I'm going to upload here all the patches I have. They are not fully green on try, and they are not ready to be reviewed yet. These patches apply on top of bug 1511436
Attached patch part 1 - login-reputation (obsolete) — — Splinter Review
Attached patch part 2 - flash factories (obsolete) — — Splinter Review
Attached patch part 3 - flash cleanup (obsolete) — — Splinter Review
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [domsecurity-active]
Blocks: 1513298
No longer depends on: 1513298
Depends on: 1511436
Depends on: 1514133
Summary: Port url-classifier clients to features → [meta] Port url-classifier clients to features
Comment on attachment 9030302 [details] [diff] [review] part 1 - login-reputation Patch moved to bug 1514133.
Attachment #9030302 - Attachment is obsolete: true
Keywords: meta
Comment on attachment 9030303 [details] [diff] [review] part 2 - flash factories Moved to bug 1514202.
Attachment #9030303 - Attachment is obsolete: true
Comment on attachment 9030304 [details] [diff] [review] part 3 - flash cleanup Moved to bug 1514202.
Attachment #9030304 - Attachment is obsolete: true
Depends on: 1516133
Depends on: 1515286, 1514697
Depends on: 1515272
Depends on: 1518082
No longer depends on: 1515272
Depends on: 1514202

I just submitted a patch for the last remaining blocker. We should close this bug.

Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Depends on: 1522265
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: