1516091 - Stop using <sidebarheader> as an element

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P5)

Description

[Tim Nguyen :ntim]

The only usage in Firefox has its own styling.

The `sidebarheader > label` selectors are completely unused in Firefox, since Firefox uses a toolbarbutton as child element.

I got a feeling that the global.css sidebarheader styles can be killed altogether for that reason, the styles in global.css are not necessarily relevant to Firefox, and they're outdated.

Comment 1

[Tim Nguyen :ntim]

There doesn't seem to be any special behaviour associated to <sidebarheader> (neither in a11y or in platform code), only styling, so it'd be reasonable to change this to a normal XUL box.

Comment 2

[Tim Nguyen :ntim]

Attachment: Bug 1516091 - Stop using <sidebarheader> as an element.

Comment 3

[Tim Nguyen :ntim]

Magnus/Richard, this is something you'd probably want to port to TB.

TB seems to have multiple sidebarheader usages, I guess they could be changed to box class="sidebar-header" and the styling could be ported over.

Comment 4

[Magnus Melin [:mkmelin]]

Thanks Tim, filed bug 1593224.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2cad80ddf5c8
Stop using <sidebarheader> as an element. r=Gijs

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/2cad80ddf5c8