1516272 - [Export] Add search hand-off, discovery stream and bug fixes to Activity Stream

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P2)

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1516272 - Add search hand-off, discovery stream and bug fixes to Activity Stream

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5990f24b16ef
Add search hand-off, discovery stream and bug fixes to Activity Stream r=k88hudson

Comment 3

[Raul Gurzau (:RaulG)]

Backed out changeset 5990f24b16ef (bug 1516272) for failing at browser_google_behavior.js on a CLOSED TREE

Backout link: https://hg.mozilla.org/integration/autoland/rev/a5a793e5d286c5c1e806860d3d5eba0493b1bccc

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&selectedJob=219664413&revision=5990f24b16efd56b80acc265ef70548481f47784

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=219664413&repo=autoland&lineNumber=3260

Log snippet: 

[task 2019-01-02T22:51:51.448Z] 22:51:51     INFO - TEST-START | browser/components/search/test/browser/browser_google_behavior.js
[task 2019-01-02T22:51:53.089Z] 22:51:53     INFO - TEST-INFO | started process screentopng
[task 2019-01-02T22:51:53.887Z] 22:51:53     INFO - TEST-INFO | screentopng: exit 0
[task 2019-01-02T22:51:53.889Z] 22:51:53     INFO - Buffered messages logged at 22:51:51
[task 2019-01-02T22:51:53.889Z] 22:51:53     INFO - Entering test bound 
[task 2019-01-02T22:51:53.892Z] 22:51:53     INFO - TEST-PASS | browser/components/search/test/browser/browser_google_behavior.js | Google is installed - {"identifier":"google-b-d","name":"Google","QueryInterface":"function QueryInterface() {\n    [native code]\n}","getSubmission":"function getSubmission() {\n    [native code]\n}","addParam":"function addParam() {\n    [native code]\n}","supportsResponseType":"function supportsResponseType() {\n    [native code]\n}","getIconURLBySize":"function getIconURLBySize() {\n    [native code]\n}","getIcons":"function getIcons() {\n    [native code]\n}","speculativeConnect":"function speculativeConnect() {\n    [native code]\n}","alias":null,"description":"Google Search","hidden":false,"iconURI":{"spec":"resource://search-plugins/images/google.ico","scheme":"resource","prePath":"resource://search-plugins","userPass":"","username":"","password":"","hostPort":"search-plugins","host":"search-plugins","port":-1,"pathQueryRef":"/images/google.ico","equals":"function equals() {\n    [native code]\n}","schemeIs":"function schemeIs() {\n    [native code]\n}","resolve":"function resolve() {\n    [native code]\n}","asciiSpec":"resource://search-plugins/images/google.ico","asciiHostPort":"search-plugins","asciiHost":"search-plugins","ref":"","equalsExceptRef":"function equalsExceptRef() {\n    [native code]\n}","specIgnoringRef":"resource://search-plugins/images/google.ico","hasRef":false,"filePath":"/images/google.ico","query":"","displayHost":"search-plugins","displayHostPort":"search-plugins","displaySpec":"resource://search-plugins/images/google.ico","displayPrePath":"resource://search-plugins","mutate":"function mutate() {\n    [native code]\n}"},"searchForm":"https://www.google.com/search?client=firefox-b-d&q=","getResultDomain":"function getResultDomain() {\n    [native code]\n}"} == true - 
[task 2019-01-02T22:51:53.893Z] 22:51:53     INFO - TEST-PASS | browser/components/search/test/browser/browser_google_behavior.js | Check search URL for 'foo' - "foo" == "foo" - 
[task 2019-01-02T22:51:53.895Z] 22:51:53     INFO - Buffered messages logged at 22:51:52
[task 2019-01-02T22:51:53.896Z] 22:51:53     INFO - Running: context menu search
[task 2019-01-02T22:51:53.897Z] 22:51:53     INFO - TEST-PASS | browser/components/search/test/browser/browser_google_behavior.js | "firefox-b-d" == "firefox-b-d" - 
[task 2019-01-02T22:51:53.898Z] 22:51:53     INFO - Running: keyword search
[task 2019-01-02T22:51:53.901Z] 22:51:53     INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“r” modifiers=“accel,alt” id=“key_toggleReaderMode”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 869}]
[task 2019-01-02T22:51:53.902Z] 22:51:53     INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“i” modifiers=“accel,alt,shift” id=“key_browserToolbox”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 869}]
[task 2019-01-02T22:51:53.911Z] 22:51:53     INFO - TEST-PASS | browser/components/search/test/browser/browser_google_behavior.js | "firefox-b-d" == "firefox-b-d" - 
[task 2019-01-02T22:51:53.914Z] 22:51:53     INFO - Running: keyword search with alias
[task 2019-01-02T22:51:53.919Z] 22:51:53     INFO - TEST-PASS | browser/components/search/test/browser/browser_google_behavior.js | "firefox-b-d" == "firefox-b-d" - 
[task 2019-01-02T22:51:53.923Z] 22:51:53     INFO - Running: search bar search
[task 2019-01-02T22:51:53.927Z] 22:51:53     INFO - TEST-PASS | browser/components/search/test/browser/browser_google_behavior.js | "firefox-b-d" == "firefox-b-d" - 
[task 2019-01-02T22:51:53.931Z] 22:51:53     INFO - Running: new tab search
[task 2019-01-02T22:51:53.933Z] 22:51:53     INFO - Buffered messages finished
[task 2019-01-02T22:51:53.935Z] 22:51:53     INFO - TEST-UNEXPECTED-FAIL | browser/components/search/test/browser/browser_google_behavior.js | Uncaught exception - TypeError: input is null
[task 2019-01-02T22:51:53.938Z] 22:51:53     INFO - Leaving test bound 
[task 2019-01-02T22:51:53.940Z] 22:51:53     INFO - GECKO(4419) | MEMORY STAT | vsize 1739MB | residentFast 307MB | heapAllocated 126MB
[task 2019-01-02T22:51:53.941Z] 22:51:53     INFO - TEST-OK | browser/components/search/test/browser/browser_google_behavior.js | took 1670ms
[task 2019-01-02T22:51:53.942Z] 22:51:53     INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-01-02T22:51:53.943Z] 22:51:53     INFO - TEST-UNEXPECTED-FAIL | browser/components/search/test/browser/browser_google_behavior.js | Found an unexpected tab at the end of test run: about:newtab - 
[task 2019-01-02T22:51:53.944Z] 22:51:53     INFO - checking window state

Comment 4

[Ed Lee :Mardak]

Oh, apparently this browser_google_behavior test is reused from a sub directory that we missed as we test with artifact builds:

https://searchfox.org/mozilla-central/source/browser/components/search/test/browser/google_codes/browser.ini

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0f59d493460
Add search hand-off, discovery stream and bug fixes to Activity Stream r=k88hudson

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/c0f59d493460