Closed Bug 1516340 Opened 5 years ago Closed 5 years ago

Perma beta browser_privacypane_2.js - deleteOnClose should not be disabled - Got true, expected false

Categories

(Firefox :: Site Identity, defect, P1)

Product:
Firefox
Component:
Site Identity
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 66
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox64 --- unaffected
firefox65 --- verified
firefox66 + verified

People

(Reporter: CosminS, Assigned: johannh)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell disable-recommended])

Attachments

(1 file)

Bug 1516340 - Properly clean up prefs in browser_contentblocking.js. r=ewright
47 bytes, text/x-phabricator-request
Details | Review 
[Tracking Requested - why for this release]:

Central as late Beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception&revision=a30fb730b7143aecb52e1a2e4e237a04190cebbe&selectedJob=218761682&searchStr=browser%2Cchrome

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=218761682&repo=try&lineNumber=10430

[task 2018-12-25T12:25:03.875Z] 12:25:03     INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_privacypane_2.js | rememberForms should not be disabled - 
[task 2018-12-25T12:25:03.876Z] 12:25:03     INFO - Buffered messages finished
[task 2018-12-25T12:25:03.877Z] 12:25:03     INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_privacypane_2.js | deleteOnClose should not be disabled - Got true, expected false
[task 2018-12-25T12:25:03.878Z] 12:25:03     INFO - Stack trace:
[task 2018-12-25T12:25:03.879Z] 12:25:03     INFO - chrome://mochikit/content/browser-test.js:test_is:1316
[task 2018-12-25T12:25:03.880Z] 12:25:03     INFO - chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/privacypane_tests_perwindow.js:expect_disabled/<:76
[task 2018-12-25T12:25:03.881Z] 12:25:03     INFO - chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/privacypane_tests_perwindow.js:expect_disabled:75
[task 2018-12-25T12:25:03.882Z] 12:25:03     INFO - chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/privacypane_tests_perwindow.js:test_dependent_elements:103
[task 2018-12-25T12:25:03.883Z] 12:25:03     INFO - chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/privacypane_tests_perwindow.js:runTestOnPrivacyPrefPane:11

This happens only on late beta simulation and looks to be a regression from Bug 1466817. Paolo could you please take a look over this? Thank you.
Flags: needinfo?(paolo.mozmail)
The only test that was changed in bug 1466817 is browser_spotlight.js, and in the log it is executed _after_ the test that fails here. The production code change seems totally unrelated to what browser_privacypane_2.js is testing. There is a new attribute added in the privacy pane implementation file, but after a quick look it seems strange that this would affect the test.

Cosmin, can you verify that the regression bug you identified is correct?
Flags: needinfo?(paolo.mozmail) → needinfo?(csabou)
Backed out bug 1466817 in beta sim and the failure is not present anymore.

Central as beta simulation:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=bd4531e9dd487fc05d38aa62b04e0b1011a0bf67
Flags: needinfo?(csabou)
Thanks! I'll check this out in the next few days.
Flags: needinfo?(paolo.mozmail)
Bug 1466817 isn't the correct regression range, as comment 1 originally suggested.

Comment 2 is irrelevant because the backout was done on an early beta simulation (66.0b1) instead of the original late beta (66.0b12), so this test would likely have succeeded even without the backout. I figured this out after spending quite some time for a full build of this changeset.

I've then built revision a30fb730b714 mentioned in comment 0 locally, and verified that browser_privacypane_2.js fails when run together with its entire test folder, but not individually:

  ./mach test browser/components/preferences/in-content/tests/

However, backing out bug 1466817 from that revision and running the tests in the folder again does not fix the failure.

You need to find the correct regression range here, and I suggest double checking the regressing bug with a cherry-picked backout and posting both the changeset that fails and the one that succeeds.
No longer blocks: 1466817
Flags: needinfo?(paolo.mozmail) → needinfo?(csabou)
Sorry for the time spent on this, Paolo.

Late beta simulation with a backout of https://hg.mozilla.org/mozilla-central/rev/724652219657 / bug 1514853 points to that bug (none of the oranges have a failure message for this test): https://treeherder.mozilla.org/#/jobs?repo=try&revision=a45702316af9a507640676f60b2847323afe2d6a

Ehsan, please take a look. This permafails on beta.
Blocks: 1514853
Flags: needinfo?(csabou) → needinfo?(ehsan)
Johann/Erica, can you please take this?  I don't have the bandwidth right now... Thanks!
Flags: needinfo?(jhofmann)
Flags: needinfo?(ewright)
Flags: needinfo?(ehsan)
status-firefox65: unaffected → affected
Keywords: intermittent-failure
Summary: Perma browser_privacypane_2.js - deleteOnClose should not be disabled - Got true, expected false → Perma beta browser_privacypane_2.js - deleteOnClose should not be disabled - Got true, expected false
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Flags: needinfo?(jhofmann)
Priority: -- → P1
Flags: needinfo?(ewright)
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/993c073ab27a
Properly clean up prefs in browser_contentblocking.js. r=ewright

https://hg.mozilla.org/mozilla-central/rev/993c073ab27a

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox66: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: